Re: [PATCH net] ipv6: make sure dev is not NULL before call ip6_frag_reasm

2017-05-09 Thread Eric Dumazet
On Tue, 2017-05-09 at 21:40 +0800, Hangbin Liu wrote: > > I saw we checked the dev in this function > > dev = skb->dev; > if (dev) { > fq->iif = dev->ifindex; > skb->dev = NULL; > } > > and upper caller ipv6_frag_rcv() > > fq = fq_find(net,

Re: [PATCH net] ipv6: make sure dev is not NULL before call ip6_frag_reasm

2017-05-09 Thread Hangbin Liu
On Mon, May 08, 2017 at 07:50:30AM -0700, Eric Dumazet wrote: > On Mon, 2017-05-08 at 11:09 +0800, Hangbin Liu wrote: > > Since ip6_frag_reasm() will call __in6_dev_get(dev), which will access > > dev->ip6_ptr. We need to make sure dev is not NULL. > > > > Signed-off-by: Hangbin Liu > > --- > >

Re: [PATCH net] ipv6: make sure dev is not NULL before call ip6_frag_reasm

2017-05-08 Thread Eric Dumazet
On Mon, 2017-05-08 at 11:09 +0800, Hangbin Liu wrote: > Since ip6_frag_reasm() will call __in6_dev_get(dev), which will access > dev->ip6_ptr. We need to make sure dev is not NULL. > > Signed-off-by: Hangbin Liu > --- > net/ipv6/reassembly.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH net] ipv6: make sure dev is not NULL before call ip6_frag_reasm

2017-05-07 Thread Hangbin Liu
Since ip6_frag_reasm() will call __in6_dev_get(dev), which will access dev->ip6_ptr. We need to make sure dev is not NULL. Signed-off-by: Hangbin Liu --- net/ipv6/reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c index