Re: [PATCH net] ipv6: fix suspicious RCU usage in rt6_dump_route()

2019-06-26 Thread David Miller
From: Eric Dumazet Date: Wed, 26 Jun 2019 03:05:28 -0700 > syzbot reminded us that rt6_nh_dump_exceptions() needs to be called > with rcu_read_lock() > > net/ipv6/route.c:1593 suspicious rcu_dereference_check() usage! > > other info that might help us debug this: ... > Fixes: 1e47b4837f3b ("ipv

Re: [PATCH net] ipv6: fix suspicious RCU usage in rt6_dump_route()

2019-06-26 Thread Stefano Brivio
On Wed, 26 Jun 2019 03:05:28 -0700 Eric Dumazet wrote: > syzbot reminded us that rt6_nh_dump_exceptions() needs to be called > with rcu_read_lock() > > net/ipv6/route.c:1593 suspicious rcu_dereference_check() usage! Thanks for fixing this too. Reviewed-by: Stefano Brivio -- Stefano

Re: [PATCH net] ipv6: fix suspicious RCU usage in rt6_dump_route()

2019-06-26 Thread Eric Dumazet
On Wed, Jun 26, 2019 at 12:05 PM Eric Dumazet wrote: > > syzbot reminded us that rt6_nh_dump_exceptions() needs to be called > with rcu_read_lock() Same remark : This is for net-next tree.

[PATCH net] ipv6: fix suspicious RCU usage in rt6_dump_route()

2019-06-26 Thread Eric Dumazet
syzbot reminded us that rt6_nh_dump_exceptions() needs to be called with rcu_read_lock() net/ipv6/route.c:1593 suspicious rcu_dereference_check() usage! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 2 locks held by syz-executor609/8966: #0: b7dbe288