Re: [PATCH net] ipv6: fix static key imbalance in fl_create()

2019-07-11 Thread David Miller
From: Eric Dumazet Date: Wed, 10 Jul 2019 06:40:11 -0700 > fl_create() should call static_branch_deferred_inc() only in > case of success. > > Also we should not call fl_free() in error path, as this could > cause a static key imbalance. ... > Fixes: 59c820b2317f ("ipv6: elide flowlabel check i

[PATCH net] ipv6: fix static key imbalance in fl_create()

2019-07-10 Thread Eric Dumazet
fl_create() should call static_branch_deferred_inc() only in case of success. Also we should not call fl_free() in error path, as this could cause a static key imbalance. jump label: negative count! WARNING: CPU: 0 PID: 15907 at kernel/jump_label.c:221 static_key_slow_try_dec kernel/jump_label.c