Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-19 Thread David Ahern
On 11/19/18 7:16 PM, David Miller wrote: > From: Xin Long > Date: Thu, 15 Nov 2018 16:23:38 +0900 > >> The attachment is the ip6_dst.sh with IPVS. >> >> # sh ip6_dst.sh > > Maybe a selftests candidate? > That script was not a reliable reproducer for me. I created a much simpler one that shows

Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-19 Thread David Miller
From: Xin Long Date: Thu, 15 Nov 2018 16:23:38 +0900 > The attachment is the ip6_dst.sh with IPVS. > > # sh ip6_dst.sh Maybe a selftests candidate?

Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-16 Thread David Miller
From: Xin Long Date: Wed, 14 Nov 2018 00:48:28 +0800 > These is no need to hold dst before calling rt6_remove_exception_rt(). > The call to dst_hold_safe() in ip6_link_failure() was for ip6_del_rt(), > which has been removed in Commit 93531c674315 ("net/ipv6: separate > handling of FIB entries fr

Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-15 Thread David Ahern
On 11/13/18 8:48 AM, Xin Long wrote: > These is no need to hold dst before calling rt6_remove_exception_rt(). > The call to dst_hold_safe() in ip6_link_failure() was for ip6_del_rt(), > which has been removed in Commit 93531c674315 ("net/ipv6: separate > handling of FIB entries from dst based route

Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-15 Thread Mika Penttilä
On 15.11.2018 20.17, David Ahern wrote: > On 11/14/18 11:23 PM, Xin Long wrote: >> On Thu, Nov 15, 2018 at 3:33 PM David Ahern wrote: >>> On 11/14/18 11:03 AM, David Ahern wrote: On 11/13/18 8:48 AM, Xin Long wrote: > These is no need to hold dst before calling rt6_remove_exception_rt().

Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-15 Thread David Ahern
On 11/14/18 11:23 PM, Xin Long wrote: > On Thu, Nov 15, 2018 at 3:33 PM David Ahern wrote: >> >> On 11/14/18 11:03 AM, David Ahern wrote: >>> On 11/13/18 8:48 AM, Xin Long wrote: These is no need to hold dst before calling rt6_remove_exception_rt(). The call to dst_hold_safe() in ip6_lin

Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-14 Thread Xin Long
On Thu, Nov 15, 2018 at 3:33 PM David Ahern wrote: > > On 11/14/18 11:03 AM, David Ahern wrote: > > On 11/13/18 8:48 AM, Xin Long wrote: > >> These is no need to hold dst before calling rt6_remove_exception_rt(). > >> The call to dst_hold_safe() in ip6_link_failure() was for ip6_del_rt(), > >> whi

Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-14 Thread David Ahern
On 11/14/18 11:03 AM, David Ahern wrote: > On 11/13/18 8:48 AM, Xin Long wrote: >> These is no need to hold dst before calling rt6_remove_exception_rt(). >> The call to dst_hold_safe() in ip6_link_failure() was for ip6_del_rt(), >> which has been removed in Commit 93531c674315 ("net/ipv6: separate

Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-14 Thread David Ahern
On 11/13/18 8:48 AM, Xin Long wrote: > These is no need to hold dst before calling rt6_remove_exception_rt(). > The call to dst_hold_safe() in ip6_link_failure() was for ip6_del_rt(), > which has been removed in Commit 93531c674315 ("net/ipv6: separate > handling of FIB entries from dst based route

[PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-13 Thread Xin Long
These is no need to hold dst before calling rt6_remove_exception_rt(). The call to dst_hold_safe() in ip6_link_failure() was for ip6_del_rt(), which has been removed in Commit 93531c674315 ("net/ipv6: separate handling of FIB entries from dst based routes"). Otherwise, it will cause a dst leak. Th