Re: [PATCH net] ipv6: don't let tb6_root node share routes with other node

2018-01-19 Thread Ido Schimmel
On Fri, Jan 19, 2018 at 01:46:02PM -0800, Wei Wang wrote: > On Fri, Jan 19, 2018 at 1:36 PM, Wei Wang wrote: > > > > > > On Fri, Jan 19, 2018 at 1:13 PM, Ido Schimmel wrote: > >> Hi Wei, Martin, > >> > >> On Thu, Jan 18, 2018 at 03:31:29PM -0800, Wei Wang wrote: > >>> On Thu, Jan 18, 2018 at 2:47

Re: [PATCH net] ipv6: don't let tb6_root node share routes with other node

2018-01-19 Thread Wei Wang
On Fri, Jan 19, 2018 at 1:36 PM, Wei Wang wrote: > > > On Fri, Jan 19, 2018 at 1:13 PM, Ido Schimmel wrote: >> Hi Wei, Martin, >> >> On Thu, Jan 18, 2018 at 03:31:29PM -0800, Wei Wang wrote: >>> On Thu, Jan 18, 2018 at 2:47 PM, Martin KaFai Lau wrote: >>> > On Thu, Jan 18, 2018 at 10:40:03AM -08

Re: [PATCH net] ipv6: don't let tb6_root node share routes with other node

2018-01-19 Thread Ido Schimmel
Hi Wei, Martin, On Thu, Jan 18, 2018 at 03:31:29PM -0800, Wei Wang wrote: > On Thu, Jan 18, 2018 at 2:47 PM, Martin KaFai Lau wrote: > > On Thu, Jan 18, 2018 at 10:40:03AM -0800, Wei Wang wrote: > >> From: Wei Wang > >> > >> After commit 4512c43eac7e, if we add a route to the subtree of tb6_root

Re: [PATCH net] ipv6: don't let tb6_root node share routes with other node

2018-01-18 Thread David Miller
From: Wei Wang Date: Thu, 18 Jan 2018 10:40:03 -0800 > From: Wei Wang > > After commit 4512c43eac7e, if we add a route to the subtree of tb6_root > which does not have any route attached to it yet, the current code will > let tb6_root and the node in the subtree share the same route. > This cou

Re: [PATCH net] ipv6: don't let tb6_root node share routes with other node

2018-01-18 Thread Martin KaFai Lau
On Thu, Jan 18, 2018 at 03:31:29PM -0800, Wei Wang wrote: > On Thu, Jan 18, 2018 at 2:47 PM, Martin KaFai Lau wrote: > > On Thu, Jan 18, 2018 at 10:40:03AM -0800, Wei Wang wrote: > >> From: Wei Wang > >> > >> After commit 4512c43eac7e, if we add a route to the subtree of tb6_root > >> which does

Re: [PATCH net] ipv6: don't let tb6_root node share routes with other node

2018-01-18 Thread Wei Wang
On Thu, Jan 18, 2018 at 2:47 PM, Martin KaFai Lau wrote: > On Thu, Jan 18, 2018 at 10:40:03AM -0800, Wei Wang wrote: >> From: Wei Wang >> >> After commit 4512c43eac7e, if we add a route to the subtree of tb6_root >> which does not have any route attached to it yet, the current code will >> let tb

Re: [PATCH net] ipv6: don't let tb6_root node share routes with other node

2018-01-18 Thread Martin KaFai Lau
On Thu, Jan 18, 2018 at 10:40:03AM -0800, Wei Wang wrote: > From: Wei Wang > > After commit 4512c43eac7e, if we add a route to the subtree of tb6_root > which does not have any route attached to it yet, the current code will > let tb6_root and the node in the subtree share the same route. > This

[PATCH net] ipv6: don't let tb6_root node share routes with other node

2018-01-18 Thread Wei Wang
From: Wei Wang After commit 4512c43eac7e, if we add a route to the subtree of tb6_root which does not have any route attached to it yet, the current code will let tb6_root and the node in the subtree share the same route. This could cause problem cause tb6_root has RTN_INFO flag marked and the tr