Re: [PATCH net] ipv6: Handle race in addrconf_dad_work

2019-09-30 Thread Eric Dumazet
On 9/30/19 7:23 PM, David Ahern wrote: > On 9/30/19 8:01 PM, Eric Dumazet wrote: >> >> >> Do we need to keep the test on IF_READY done later in this function ? >> >> If IF_READY can disappear only under RTNL, we might clean this. >> >> (unless addrconf_dad_work() releases rtnl and reacquires it

Re: [PATCH net] ipv6: Handle race in addrconf_dad_work

2019-09-30 Thread David Ahern
On 9/30/19 8:01 PM, Eric Dumazet wrote: > > > On 9/30/19 6:37 PM, David Ahern wrote: >> From: David Ahern >> >> Rajendra reported a kernel panic when a link was taken down: >> >> [ 6870.263084] BUG: unable to handle kernel NULL pointer dereference at >> 00a8 >> [ 6870.271856] IP: []

Re: [PATCH net] ipv6: Handle race in addrconf_dad_work

2019-09-30 Thread Eric Dumazet
On 9/30/19 6:37 PM, David Ahern wrote: > From: David Ahern > > Rajendra reported a kernel panic when a link was taken down: > > [ 6870.263084] BUG: unable to handle kernel NULL pointer dereference at > 00a8 > [ 6870.271856] IP: [] __ipv6_ifa_notify+0x154/0x290 > > > > [ 6870.5

[PATCH net] ipv6: Handle race in addrconf_dad_work

2019-09-30 Thread David Ahern
From: David Ahern Rajendra reported a kernel panic when a link was taken down: [ 6870.263084] BUG: unable to handle kernel NULL pointer dereference at 00a8 [ 6870.271856] IP: [] __ipv6_ifa_notify+0x154/0x290 [ 6870.570501] Call Trace: [ 6870.573238] [] ? ipv6_ifa_notify+0x26/0x40