Re: [PATCH net] ipv6: A few fixes on dereferencing rt->from

2019-05-01 Thread David Miller
From: Martin KaFai Lau Date: Tue, 30 Apr 2019 10:45:12 -0700 > It is a followup after the fix in > commit 9c69a1320515 ("route: Avoid crash from dereferencing NULL rt->from") > > rt6_do_redirect(): > 1. NULL checking is needed on rt->from because a parallel >fib6_info delete could happen tha

Re: [PATCH net] ipv6: A few fixes on dereferencing rt->from

2019-05-01 Thread Eric Dumazet
On 4/30/19 10:45 AM, Martin KaFai Lau wrote: > It is a followup after the fix in > commit 9c69a1320515 ("route: Avoid crash from dereferencing NULL rt->from") > > rt6_do_redirect(): > 1. NULL checking is needed on rt->from because a parallel >fib6_info delete could happen that sets rt->from

Re: [PATCH net] ipv6: A few fixes on dereferencing rt->from

2019-05-01 Thread David Ahern
On 4/30/19 11:45 AM, Martin KaFai Lau wrote: > It is a followup after the fix in > commit 9c69a1320515 ("route: Avoid crash from dereferencing NULL rt->from") > > rt6_do_redirect(): > 1. NULL checking is needed on rt->from because a parallel >fib6_info delete could happen that sets rt->from to

Re: [PATCH net] ipv6: A few fixes on dereferencing rt->from

2019-04-30 Thread Wei Wang
On Tue, Apr 30, 2019 at 10:45 AM Martin KaFai Lau wrote: > > It is a followup after the fix in > commit 9c69a1320515 ("route: Avoid crash from dereferencing NULL rt->from") > > rt6_do_redirect(): > 1. NULL checking is needed on rt->from because a parallel >fib6_info delete could happen that se

[PATCH net] ipv6: A few fixes on dereferencing rt->from

2019-04-30 Thread Martin KaFai Lau
It is a followup after the fix in commit 9c69a1320515 ("route: Avoid crash from dereferencing NULL rt->from") rt6_do_redirect(): 1. NULL checking is needed on rt->from because a parallel fib6_info delete could happen that sets rt->from to NULL. (e.g. rt6_remove_exception() and fib6_drop_pcpu