Re: [PATCH net] ipv4: mpls: fix mpls_xmit for iptunnel

2019-08-25 Thread David Miller
From: Alexey Kodanev Date: Fri, 23 Aug 2019 20:51:43 +0300 > When using mpls over gre/gre6 setup, rt->rt_gw4 address is not set, the > same for rt->rt_gw_family. Therefore, when rt->rt_gw_family is checked > in mpls_xmit(), neigh_xmit() call is skipped. As a result, such setup > doesn't work any

Re: [PATCH net] ipv4: mpls: fix mpls_xmit for iptunnel

2019-08-25 Thread David Ahern
On 8/23/19 11:51 AM, Alexey Kodanev wrote: > When using mpls over gre/gre6 setup, rt->rt_gw4 address is not set, the > same for rt->rt_gw_family. Therefore, when rt->rt_gw_family is checked > in mpls_xmit(), neigh_xmit() call is skipped. As a result, such setup > doesn't work anymore. > > This is

Re: [PATCH net] ipv4: mpls: fix mpls_xmit for iptunnel

2019-08-23 Thread David Miller
From: David Ahern Date: Fri, 23 Aug 2019 13:59:05 -0400 > I am traveling today and doubt I will be able to take a deep look at > this until Monday. I'll wait until you've had a chance to review this properly.

Re: [PATCH net] ipv4: mpls: fix mpls_xmit for iptunnel

2019-08-23 Thread David Ahern
On 8/23/19 1:51 PM, Alexey Kodanev wrote: > When using mpls over gre/gre6 setup, rt->rt_gw4 address is not set, the > same for rt->rt_gw_family. Therefore, when rt->rt_gw_family is checked > in mpls_xmit(), neigh_xmit() call is skipped. As a result, such setup > doesn't work anymore. > > This iss

[PATCH net] ipv4: mpls: fix mpls_xmit for iptunnel

2019-08-23 Thread Alexey Kodanev
When using mpls over gre/gre6 setup, rt->rt_gw4 address is not set, the same for rt->rt_gw_family. Therefore, when rt->rt_gw_family is checked in mpls_xmit(), neigh_xmit() call is skipped. As a result, such setup doesn't work anymore. This issue was found with LTP mpls03 tests. Fixes: 1550c17193