Re: [PATCH net] ipv4: fix use-after-free in ip_cmsg_recv_dstaddr()

2018-10-02 Thread David Miller
From: Eric Dumazet Date: Sun, 30 Sep 2018 11:33:39 -0700 > Caching ip_hdr(skb) before a call to pskb_may_pull() is buggy, > do not do it. > > Fixes: 2efd4fca703a ("ip: in cmsg IP(V6)_ORIGDSTADDR call pskb_may_pull") > Signed-off-by: Eric Dumazet > Cc: Willem de Bruijn > Reported-by: syzbot A

Re: [PATCH net] ipv4: fix use-after-free in ip_cmsg_recv_dstaddr()

2018-09-30 Thread Willem de Bruijn
On Sun, Sep 30, 2018 at 2:37 PM Eric Dumazet wrote: > > Caching ip_hdr(skb) before a call to pskb_may_pull() is buggy, > do not do it. > > Fixes: 2efd4fca703a ("ip: in cmsg IP(V6)_ORIGDSTADDR call pskb_may_pull") > Signed-off-by: Eric Dumazet > Cc: Willem de Bruijn > Reported-by: syzbot Acked-

[PATCH net] ipv4: fix use-after-free in ip_cmsg_recv_dstaddr()

2018-09-30 Thread Eric Dumazet
Caching ip_hdr(skb) before a call to pskb_may_pull() is buggy, do not do it. Fixes: 2efd4fca703a ("ip: in cmsg IP(V6)_ORIGDSTADDR call pskb_may_pull") Signed-off-by: Eric Dumazet Cc: Willem de Bruijn Reported-by: syzbot --- net/ipv4/ip_sockglue.c | 3 +-- 1 file changed, 1 insertion(+), 2 dele