Re: [PATCH net] ipv4: fix suspicious RCU usage in fib_dump_info_fnhe()

2019-06-26 Thread David Miller
From: Eric Dumazet Date: Wed, 26 Jun 2019 03:04:50 -0700 > sysbot reported that we lack appropriate rcu_read_lock() > protection in fib_dump_info_fnhe() > > net/ipv4/route.c:2875 suspicious rcu_dereference_check() usage! > > other info that might help us debug this: ... > Fixes: ee28906fd7a1 (

Re: [PATCH net] ipv4: fix suspicious RCU usage in fib_dump_info_fnhe()

2019-06-26 Thread Stefano Brivio
On Wed, 26 Jun 2019 03:04:50 -0700 Eric Dumazet wrote: > sysbot reported that we lack appropriate rcu_read_lock() > protection in fib_dump_info_fnhe() Thanks for fixing this. > diff --git a/net/ipv4/route.c b/net/ipv4/route.c > index > 6aee412a68bdd3c24a6a0eb9883e04b7a83998e0..59670fafcd2612b9

Re: [PATCH net] ipv4: fix suspicious RCU usage in fib_dump_info_fnhe()

2019-06-26 Thread Eric Dumazet
On Wed, Jun 26, 2019 at 12:04 PM Eric Dumazet wrote: > > sysbot reported that we lack appropriate rcu_read_lock() > protection in fib_dump_info_fnhe() This is for net-next tree, sorry for the confusion.

[PATCH net] ipv4: fix suspicious RCU usage in fib_dump_info_fnhe()

2019-06-26 Thread Eric Dumazet
sysbot reported that we lack appropriate rcu_read_lock() protection in fib_dump_info_fnhe() net/ipv4/route.c:2875 suspicious rcu_dereference_check() usage! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 1 lock held by syz-executor609/8966: #0: b7dbe2