Re: [PATCH net] ipv4: ensure rcu_read_lock() in ipv4_link_failure()

2019-04-14 Thread Eric Dumazet
On 04/14/2019 01:44 PM, David Miller wrote: > From: Eric Dumazet > Date: Sat, 13 Apr 2019 17:32:21 -0700 > >> fib_compute_spec_dst() needs to be called under rcu protection. >> >> syzbot reported : > ... >> Fixes: ed0de45a1008 ("ipv4: recompile ip options in ipv4_link_failure") >> Signed-off-

Re: [PATCH net] ipv4: ensure rcu_read_lock() in ipv4_link_failure()

2019-04-14 Thread David Miller
From: Eric Dumazet Date: Sat, 13 Apr 2019 17:32:21 -0700 > fib_compute_spec_dst() needs to be called under rcu protection. > > syzbot reported : ... > Fixes: ed0de45a1008 ("ipv4: recompile ip options in ipv4_link_failure") > Signed-off-by: Eric Dumazet > Reported-by: syzbot Applied, thanks E

Re: [PATCH net] ipv4: ensure rcu_read_lock() in ipv4_link_failure()

2019-04-13 Thread Stephen Suryaputra
Thank you. The one in cipso_v4_error needs the same fix (?) Add Nazarov Sergey. On Sat, Apr 13, 2019 at 05:32:21PM -0700, Eric Dumazet wrote: > fib_compute_spec_dst() needs to be called under rcu protection. > > syzbot reported : > > WARNING: suspicious RCU usage > 5.1.0-rc4+ #165 Not tainted >

[PATCH net] ipv4: ensure rcu_read_lock() in ipv4_link_failure()

2019-04-13 Thread Eric Dumazet
fib_compute_spec_dst() needs to be called under rcu protection. syzbot reported : WARNING: suspicious RCU usage 5.1.0-rc4+ #165 Not tainted include/linux/inetdevice.h:220 suspicious rcu_dereference_check() usage! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks =