Re: [PATCH net] ipv4: early demux should be aware of fragments

2016-01-29 Thread Eric Dumazet
On Fri, 2016-01-29 at 12:24 -0800, David Miller wrote: > > This should be fixed now, thanks for letting me know. Perfect, thanks !

Re: [PATCH net] ipv4: early demux should be aware of fragments

2016-01-29 Thread David Miller
From: Eric Dumazet Date: Fri, 29 Jan 2016 07:22:06 -0800 > On Wed, 2016-01-27 at 17:02 -0500, David Miller wrote: >> From: Eric Dumazet >> Date: Tue, 26 Jan 2016 16:59:42 -0800 >> >> > From: Eric Dumazet >> > >> > We should not assume a valid protocol header is present, >> > as this is not th

Re: [PATCH net] ipv4: early demux should be aware of fragments

2016-01-29 Thread Eric Dumazet
On Wed, 2016-01-27 at 17:02 -0500, David Miller wrote: > From: Eric Dumazet > Date: Tue, 26 Jan 2016 16:59:42 -0800 > > > From: Eric Dumazet > > > > We should not assume a valid protocol header is present, > > as this is not the case for IPv4 fragments. > > > > Lets avoid extra cache line miss

Re: [PATCH net] ipv4: early demux should be aware of fragments

2016-01-27 Thread David Miller
From: Eric Dumazet Date: Tue, 26 Jan 2016 16:59:42 -0800 > From: Eric Dumazet > > We should not assume a valid protocol header is present, > as this is not the case for IPv4 fragments. > > Lets avoid extra cache line misses and potential bugs > if we actually find a socket and incorrectly uses

[PATCH net] ipv4: early demux should be aware of fragments

2016-01-26 Thread Eric Dumazet
From: Eric Dumazet We should not assume a valid protocol header is present, as this is not the case for IPv4 fragments. Lets avoid extra cache line misses and potential bugs if we actually find a socket and incorrectly uses its dst. Signed-off-by: Eric Dumazet --- net/ipv4/ip_input.c |5 +