Re: [PATCH net] ipv4: add reference counting to metrics

2017-05-26 Thread David Miller
From: Eric Dumazet Date: Thu, 25 May 2017 14:27:35 -0700 > From: Eric Dumazet > > Andrey Konovalov reported crashes in ipv4_mtu() > > I could reproduce the issue with KASAN kernels, between > 10.246.7.151 and 10.246.7.152 : > > 1) 20 concurrent netperf -t TCP_RR -H 10.246.7.152 -l 1000 & > >

Re: [PATCH net] ipv4: add reference counting to metrics

2017-05-26 Thread Cong Wang
On Fri, May 26, 2017 at 10:13 AM, Eric Dumazet wrote: > On Fri, May 26, 2017 at 10:08 AM, Cong Wang wrote: >> On Thu, May 25, 2017 at 2:27 PM, Eric Dumazet wrote: > >> Just one nit below. >> >>> -const u32 dst_default_metrics[RTAX_MAX + 1] = { >>> +const struct dst_metrics dst_default_metrics =

Re: [PATCH net] ipv4: add reference counting to metrics

2017-05-26 Thread Eric Dumazet
On Fri, May 26, 2017 at 10:08 AM, Cong Wang wrote: > On Thu, May 25, 2017 at 2:27 PM, Eric Dumazet wrote: > Just one nit below. > >> -const u32 dst_default_metrics[RTAX_MAX + 1] = { >> +const struct dst_metrics dst_default_metrics = { >> /* This initializer is needed to force linker to p

Re: [PATCH net] ipv4: add reference counting to metrics

2017-05-26 Thread Cong Wang
On Thu, May 25, 2017 at 2:27 PM, Eric Dumazet wrote: > From: Eric Dumazet > > Andrey Konovalov reported crashes in ipv4_mtu() > > I could reproduce the issue with KASAN kernels, between > 10.246.7.151 and 10.246.7.152 : > > 1) 20 concurrent netperf -t TCP_RR -H 10.246.7.152 -l 1000 & > > 2) At th

Re: [PATCH net] ipv4: add reference counting to metrics

2017-05-25 Thread Julian Anastasov
Hello, On Thu, 25 May 2017, Eric Dumazet wrote: > From: Eric Dumazet > > Andrey Konovalov reported crashes in ipv4_mtu() > > I could reproduce the issue with KASAN kernels, between > 10.246.7.151 and 10.246.7.152 : > > 1) 20 concurrent netperf -t TCP_RR -H 10.246.7.152 -l 1000 & > >

[PATCH net] ipv4: add reference counting to metrics

2017-05-25 Thread Eric Dumazet
From: Eric Dumazet Andrey Konovalov reported crashes in ipv4_mtu() I could reproduce the issue with KASAN kernels, between 10.246.7.151 and 10.246.7.152 : 1) 20 concurrent netperf -t TCP_RR -H 10.246.7.152 -l 1000 & 2) At the same time run following loop : while : do ip ro add 10.246.7.152 de