Re: [PATCH net] ipv4: Silence suspicious RCU usage warning

2020-08-26 Thread David Miller
From: Ido Schimmel Date: Wed, 26 Aug 2020 19:48:10 +0300 > From: Ido Schimmel > > fib_info_notify_update() is always called with RTNL held, but not from > an RCU read-side critical section. This leads to the following warning > [1] when the FIB table list is traversed with > hlist_for_each_entr

Re: [PATCH net] ipv4: Silence suspicious RCU usage warning

2020-08-26 Thread David Ahern
On 8/26/20 10:48 AM, Ido Schimmel wrote: > From: Ido Schimmel > > fib_info_notify_update() is always called with RTNL held, but not from > an RCU read-side critical section. This leads to the following warning > [1] when the FIB table list is traversed with > hlist_for_each_entry_rcu(), but witho

[PATCH net] ipv4: Silence suspicious RCU usage warning

2020-08-26 Thread Ido Schimmel
From: Ido Schimmel fib_info_notify_update() is always called with RTNL held, but not from an RCU read-side critical section. This leads to the following warning [1] when the FIB table list is traversed with hlist_for_each_entry_rcu(), but without a proper lockdep expression. Since modification o

Re: [PATCH net] ipv4: Silence suspicious RCU usage warning

2020-07-29 Thread David Miller
From: Ido Schimmel Date: Wed, 29 Jul 2020 11:37:13 +0300 > From: Ido Schimmel > > fib_trie_unmerge() is called with RTNL held, but not from an RCU > read-side critical section. This leads to the following warning [1] when > the FIB alias list in a leaf is traversed with > hlist_for_each_entry_r

[PATCH net] ipv4: Silence suspicious RCU usage warning

2020-07-29 Thread Ido Schimmel
From: Ido Schimmel fib_trie_unmerge() is called with RTNL held, but not from an RCU read-side critical section. This leads to the following warning [1] when the FIB alias list in a leaf is traversed with hlist_for_each_entry_rcu(). Since the function is always called with RTNL held and since mod