Re: [PATCH net] ip_gre: clear feature flags when incompatible o_flags are set

2018-04-10 Thread David Miller
From: Sabrina Dubroca Date: Tue, 10 Apr 2018 12:57:18 +0200 > Commit dd9d598c6657 ("ip_gre: add the support for i/o_flags update via > netlink") added the ability to change o_flags, but missed that the > GSO/LLTX features are disabled by default, and only enabled some gre > features are unused. T

Re: [PATCH net] ip_gre: clear feature flags when incompatible o_flags are set

2018-04-10 Thread William Tu
On Tue, Apr 10, 2018 at 6:10 AM, Xin Long wrote: > On Tue, Apr 10, 2018 at 6:57 PM, Sabrina Dubroca wrote: >> Commit dd9d598c6657 ("ip_gre: add the support for i/o_flags update via >> netlink") added the ability to change o_flags, but missed that the >> GSO/LLTX features are disabled by default,

Re: [PATCH net] ip_gre: clear feature flags when incompatible o_flags are set

2018-04-10 Thread Xin Long
On Tue, Apr 10, 2018 at 6:57 PM, Sabrina Dubroca wrote: > Commit dd9d598c6657 ("ip_gre: add the support for i/o_flags update via > netlink") added the ability to change o_flags, but missed that the > GSO/LLTX features are disabled by default, and only enabled some gre > features are unused. Thus w

[PATCH net] ip_gre: clear feature flags when incompatible o_flags are set

2018-04-10 Thread Sabrina Dubroca
Commit dd9d598c6657 ("ip_gre: add the support for i/o_flags update via netlink") added the ability to change o_flags, but missed that the GSO/LLTX features are disabled by default, and only enabled some gre features are unused. Thus we also need to disable the GSO/LLTX features on the device when t