Re: [PATCH net] ip6_tunnel: be careful when accessing the inner header

2018-09-24 Thread Paolo Abeni
On Fri, 2018-09-21 at 11:51 -0700, Cong Wang wrote: > On Wed, Sep 19, 2018 at 6:04 AM Paolo Abeni wrote: > > diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c > > index 419960b0ba16..a0b6932c3afd 100644 > > --- a/net/ipv6/ip6_tunnel.c > > +++ b/net/ipv6/ip6_tunnel.c > > @@ -1234,7 +1234,7

Re: [PATCH net] ip6_tunnel: be careful when accessing the inner header

2018-09-21 Thread Cong Wang
On Wed, Sep 19, 2018 at 6:04 AM Paolo Abeni wrote: > diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c > index 419960b0ba16..a0b6932c3afd 100644 > --- a/net/ipv6/ip6_tunnel.c > +++ b/net/ipv6/ip6_tunnel.c > @@ -1234,7 +1234,7 @@ static inline int > ip4ip6_tnl_xmit(struct sk_buff *skb, st

Re: [PATCH net] ip6_tunnel: be careful when accessing the inner header

2018-09-19 Thread David Miller
From: Paolo Abeni Date: Wed, 19 Sep 2018 15:02:07 +0200 > the ip6 tunnel xmit ndo assumes that the processed skb always > contains an ip[v6] header, but syzbot has found a way to send > frames that fall short of this assumption, leading to the following splat: ... > This change addresses the iss

[PATCH net] ip6_tunnel: be careful when accessing the inner header

2018-09-19 Thread Paolo Abeni
the ip6 tunnel xmit ndo assumes that the processed skb always contains an ip[v6] header, but syzbot has found a way to send frames that fall short of this assumption, leading to the following splat: BUG: KMSAN: uninit-value in ip6ip6_tnl_xmit net/ipv6/ip6_tunnel.c:1307 [inline] BUG: KMSAN: uninit-