Re: [PATCH net] ip: report the original address of ICMP messages

2015-06-24 Thread David Miller
From: Julian Anastasov Date: Tue, 23 Jun 2015 08:34:39 +0300 > ICMP messages can trigger ICMP and local errors. In this case > serr->port is 0 and starting from Linux 4.0 we do not return > the original target address to the error queue readers. > Add function to define which errors provide addr_

Re: [PATCH net] ip: report the original address of ICMP messages

2015-06-23 Thread Willem de Bruijn
On Tue, Jun 23, 2015 at 4:06 PM, Julian Anastasov wrote: > > Hello, > > On Tue, 23 Jun 2015, Willem de Bruijn wrote: > >> > It is using IP_RECVERR and may be relying only on >> > original address returned in msg_name from MSG_ERRQUEUE. >> >> It's not very important, in that even if

Re: [PATCH net] ip: report the original address of ICMP messages

2015-06-23 Thread Julian Anastasov
Hello, On Tue, 23 Jun 2015, Willem de Bruijn wrote: > > It is using IP_RECVERR and may be relying only on > > original address returned in msg_name from MSG_ERRQUEUE. > > It's not very important, in that even if ping does not use this > msg_name, another tool very well might. Bu

Re: [PATCH net] ip: report the original address of ICMP messages

2015-06-23 Thread Willem de Bruijn
On Tue, Jun 23, 2015 at 2:55 PM, Julian Anastasov wrote: > > Hello, > > On Tue, 23 Jun 2015, Willem de Bruijn wrote: > >> The ping utility from iputils relies on cmsg IP_RECVERR to get >> the source address on icmp errors, not on msg_name, so that >> worked for me both before and after app

Re: [PATCH net] ip: report the original address of ICMP messages

2015-06-23 Thread Julian Anastasov
Hello, On Tue, 23 Jun 2015, Willem de Bruijn wrote: > The ping utility from iputils relies on cmsg IP_RECVERR to get > the source address on icmp errors, not on msg_name, so that > worked for me both before and after applying the patch. I used > `ping -t 2 $hostname` to trigger a TTL exc

Re: [PATCH net] ip: report the original address of ICMP messages

2015-06-23 Thread Willem de Bruijn
> ICMP messages can trigger ICMP and local errors. In this case > serr->port is 0 and starting from Linux 4.0 we do not return > the original target address to the error queue readers. > Add function to define which errors provide addr_offset. > With this fix my ping command is not silent anymore.

[PATCH net] ip: report the original address of ICMP messages

2015-06-22 Thread Julian Anastasov
ICMP messages can trigger ICMP and local errors. In this case serr->port is 0 and starting from Linux 4.0 we do not return the original target address to the error queue readers. Add function to define which errors provide addr_offset. With this fix my ping command is not silent anymore. Fixes: c2