Re: [PATCH net] inet: make sure to grab rcu_read_lock before using ireq->ireq_opt

2018-10-02 Thread David Miller
From: Eric Dumazet Date: Tue, 2 Oct 2018 12:35:05 -0700 > Timer handlers do not imply rcu_read_lock(), so my recent fix > triggered a LOCKDEP warning when SYNACK is retransmit. > > Lets add rcu_read_lock()/rcu_read_unlock() pairs around ireq->ireq_opt > usages instead of guessing what is done b

[PATCH net] inet: make sure to grab rcu_read_lock before using ireq->ireq_opt

2018-10-02 Thread Eric Dumazet
Timer handlers do not imply rcu_read_lock(), so my recent fix triggered a LOCKDEP warning when SYNACK is retransmit. Lets add rcu_read_lock()/rcu_read_unlock() pairs around ireq->ireq_opt usages instead of guessing what is done by callers, since it is not worth the pain. Get rid of ireq_opt_deref