Re: [PATCH net] ieee802154: lowpan_header_create check must check daddr

2018-12-24 Thread David Miller
From: Willem de Bruijn Date: Sun, 23 Dec 2018 12:52:18 -0500 > From: Willem de Bruijn > > Packet sockets may call dev_header_parse with NULL daddr. Make > lowpan_header_ops.create fail. > > Fixes: 87a93e4eceb4 ("ieee802154: change needed headroom/tailroom") > Signed-off-by: Willem de Bruijn

Re: [PATCH net] ieee802154: lowpan_header_create check must check daddr

2018-12-24 Thread Alexander Aring
On Sun, Dec 23, 2018 at 07:45:08PM -0500, Willem de Bruijn wrote: ... > > I had some questions when I was digging AF_PACKET code. So the UAPI > > limitation of AF_PACKET has a sockaddr_t of 8 bytes. > > Do you mean the size of sll_addr in struct sockaddr_ll? > yes. > It is possible to pass larg

Re: [PATCH net] ieee802154: lowpan_header_create check must check daddr

2018-12-23 Thread Willem de Bruijn
On Sun, Dec 23, 2018 at 3:45 PM Alexander Aring wrote: > > Hi, > > thanks Willem to take a look into these callbacks. > > On Sun, Dec 23, 2018 at 12:52:18PM -0500, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Packet sockets may call dev_header_parse with NULL daddr. Make > > lowpan_

Re: [PATCH net] ieee802154: lowpan_header_create check must check daddr

2018-12-23 Thread Alexander Aring
Hi, ... > I need to admit, I never tried AF_PACKET on a lowpan interface but I > thought about it that it ends in bad things... I would like to forbid > it, because they should use RAW IPv6 sockets where at least we already > have code to check that we have at least a IPv6 header at > skb_packer_

Re: [PATCH net] ieee802154: lowpan_header_create check must check daddr

2018-12-23 Thread Alexander Aring
Hi, thanks Willem to take a look into these callbacks. On Sun, Dec 23, 2018 at 12:52:18PM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Packet sockets may call dev_header_parse with NULL daddr. Make > lowpan_header_ops.create fail. > Ok. > Fixes: 87a93e4eceb4 ("ieee802154: chan

[PATCH net] ieee802154: lowpan_header_create check must check daddr

2018-12-23 Thread Willem de Bruijn
From: Willem de Bruijn Packet sockets may call dev_header_parse with NULL daddr. Make lowpan_header_ops.create fail. Fixes: 87a93e4eceb4 ("ieee802154: change needed headroom/tailroom") Signed-off-by: Willem de Bruijn --- Re: function comment on packet socket address length: that is (now) veri