Re: [PATCH net] ibmvnic: continue fatal error reset after passive init

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 14:10:32 -0600 Lijun Pan wrote: > On Wed, Dec 23, 2020 at 10:50 AM Jakub Kicinski wrote: > > > > On Wed, 23 Dec 2020 02:21:09 -0600 Lijun Pan wrote: > > > On Tue, Dec 22, 2020 at 8:48 PM Jakub Kicinski wrote: > > > > On Sat, 19 Dec 2020 15:40:34 -0600 Lijun Pan wrote: >

Re: [PATCH net] ibmvnic: continue fatal error reset after passive init

2020-12-23 Thread Lijun Pan
On Wed, Dec 23, 2020 at 10:50 AM Jakub Kicinski wrote: > > On Wed, 23 Dec 2020 02:21:09 -0600 Lijun Pan wrote: > > On Tue, Dec 22, 2020 at 8:48 PM Jakub Kicinski wrote: > > > On Sat, 19 Dec 2020 15:40:34 -0600 Lijun Pan wrote: > > > > Commit f9c6cea0b385 ("ibmvnic: Skip fatal error reset after pa

Re: [PATCH net] ibmvnic: continue fatal error reset after passive init

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 02:21:09 -0600 Lijun Pan wrote: > On Tue, Dec 22, 2020 at 8:48 PM Jakub Kicinski wrote: > > On Sat, 19 Dec 2020 15:40:34 -0600 Lijun Pan wrote: > > > Commit f9c6cea0b385 ("ibmvnic: Skip fatal error reset after passive init") > > > says "If the passive > > > CRQ initialization

Re: [PATCH net] ibmvnic: continue fatal error reset after passive init

2020-12-23 Thread Lijun Pan
On Tue, Dec 22, 2020 at 8:48 PM Jakub Kicinski wrote: > > On Sat, 19 Dec 2020 15:40:34 -0600 Lijun Pan wrote: > > Commit f9c6cea0b385 ("ibmvnic: Skip fatal error reset after passive init") > > says "If the passive > > CRQ initialization occurs before the FATAL reset task is processed, > > the FATA

Re: [PATCH net] ibmvnic: continue fatal error reset after passive init

2020-12-22 Thread Jakub Kicinski
On Sat, 19 Dec 2020 15:40:34 -0600 Lijun Pan wrote: > Commit f9c6cea0b385 ("ibmvnic: Skip fatal error reset after passive init") > says "If the passive > CRQ initialization occurs before the FATAL reset task is processed, > the FATAL error reset task would try to access a CRQ message queue > that w

[PATCH net] ibmvnic: continue fatal error reset after passive init

2020-12-19 Thread Lijun Pan
Commit f9c6cea0b385 ("ibmvnic: Skip fatal error reset after passive init") says "If the passive CRQ initialization occurs before the FATAL reset task is processed, the FATAL error reset task would try to access a CRQ message queue that was freed, causing an oops. The problem may be most likely to o