RE: [Intel-wired-lan] [PATCH net] iavf: fix double-release of rtnl_lock

2020-12-14 Thread Jankowski, Konrad0
> -Original Message- > From: Intel-wired-lan On Behalf Of > Jakub Kicinski > Sent: czwartek, 3 grudnia 2020 18:41 > To: Nguyen, Anthony L > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; Pawlak, Jakub > > Subject: Re: [Intel-wired-lan] [PAT

Re: [PATCH net] iavf: fix double-release of rtnl_lock

2020-12-03 Thread Jakub Kicinski
On Thu, 3 Dec 2020 17:04:14 + Nguyen, Anthony L wrote: > On Wed, 2020-12-02 at 18:18 -0800, Jakub Kicinski wrote: > > This code does not jump to exit on an error in iavf_lan_add_device(), > > so the rtnl_unlock() from the normal path will follow. > > > > Fixes: b66c7bc1cd4d ("iavf: Refactor in

Re: [PATCH net] iavf: fix double-release of rtnl_lock

2020-12-03 Thread Nguyen, Anthony L
On Wed, 2020-12-02 at 18:18 -0800, Jakub Kicinski wrote: > This code does not jump to exit on an error in iavf_lan_add_device(), > so the rtnl_unlock() from the normal path will follow. > > Fixes: b66c7bc1cd4d ("iavf: Refactor init state machine") > Signed-off-by: Jakub Kicinski > --- > drivers/

[PATCH net] iavf: fix double-release of rtnl_lock

2020-12-02 Thread Jakub Kicinski
This code does not jump to exit on an error in iavf_lan_add_device(), so the rtnl_unlock() from the normal path will follow. Fixes: b66c7bc1cd4d ("iavf: Refactor init state machine") Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/intel/iavf/iavf_main.c | 4 +--- 1 file changed, 1 inserti