Re: [PATCH net] hinic: fix rewaking txq after netif_tx_disable

2020-09-08 Thread luobin (L)
On 2020/9/8 5:28, Jakub Kicinski wrote: > On Mon, 7 Sep 2020 22:15:16 +0800 Luo bin wrote: >> When calling hinic_close in hinic_set_channels, all queues are >> stopped after netif_tx_disable, but some queue may be rewaken in >> free_tx_poll by mistake while drv is handling tx irq. If one queue >> i

Re: [PATCH net] hinic: fix rewaking txq after netif_tx_disable

2020-09-07 Thread Jakub Kicinski
On Mon, 7 Sep 2020 22:15:16 +0800 Luo bin wrote: > When calling hinic_close in hinic_set_channels, all queues are > stopped after netif_tx_disable, but some queue may be rewaken in > free_tx_poll by mistake while drv is handling tx irq. If one queue > is rewaken core may call hinic_xmit_frame to se

[PATCH net] hinic: fix rewaking txq after netif_tx_disable

2020-09-07 Thread Luo bin
When calling hinic_close in hinic_set_channels, all queues are stopped after netif_tx_disable, but some queue may be rewaken in free_tx_poll by mistake while drv is handling tx irq. If one queue is rewaken core may call hinic_xmit_frame to send pkt after netif_tx_disable within a short time which m