Re: [PATCH net] gre: do not pull header in ICMP error processing

2016-05-01 Thread David Miller
From: Jiri Benc Date: Fri, 29 Apr 2016 23:31:32 +0200 > iptunnel_pull_header expects that IP header was already pulled; with this > expectation, it pulls the tunnel header. This is not true in gre_err. > Furthermore, ipv4_update_pmtu and ipv4_redirect expect that skb->data points > to the IP head

[PATCH net] gre: do not pull header in ICMP error processing

2016-04-29 Thread Jiri Benc
iptunnel_pull_header expects that IP header was already pulled; with this expectation, it pulls the tunnel header. This is not true in gre_err. Furthermore, ipv4_update_pmtu and ipv4_redirect expect that skb->data points to the IP header. We cannot pull the tunnel header in this path. It's just a