Re: [PATCH net] fou, fou6: do not assume linear skbs

2019-01-11 Thread Eric Dumazet
On Fri, Jan 11, 2019 at 6:20 AM Eric Dumazet wrote: > > On Fri, Jan 11, 2019 at 6:15 AM Stefano Brivio wrote: > > > > On Fri, 11 Jan 2019 04:55:52 -0800 > > Eric Dumazet wrote: > > > > > Both gue_err() and gue6_err() incorrectly assume > > > linear skbs. Fix them to use pskb_may_pull(). > > > >

Re: [PATCH net] fou, fou6: do not assume linear skbs

2019-01-11 Thread Eric Dumazet
On Fri, Jan 11, 2019 at 6:15 AM Stefano Brivio wrote: > > On Fri, 11 Jan 2019 04:55:52 -0800 > Eric Dumazet wrote: > > > Both gue_err() and gue6_err() incorrectly assume > > linear skbs. Fix them to use pskb_may_pull(). > > Thanks for fixing this! I stupidly didn't suspect we could get > non-line

Re: [PATCH net] fou, fou6: do not assume linear skbs

2019-01-11 Thread Stefano Brivio
On Fri, 11 Jan 2019 04:55:52 -0800 Eric Dumazet wrote: > Both gue_err() and gue6_err() incorrectly assume > linear skbs. Fix them to use pskb_may_pull(). Thanks for fixing this! I stupidly didn't suspect we could get non-linear skbs there. Just two things: > +++ b/net/ipv4/fou.c > @@ -1020,10 +

[PATCH net] fou, fou6: do not assume linear skbs

2019-01-11 Thread Eric Dumazet
Both gue_err() and gue6_err() incorrectly assume linear skbs. Fix them to use pskb_may_pull(). BUG: KMSAN: uninit-value in gue6_err+0x475/0xc40 net/ipv6/fou6.c:101 CPU: 0 PID: 18083 Comm: syz-executor1 Not tainted 5.0.0-rc1+ #7 Hardware name: Google Google Compute Engine/Google Compute Engine, BIO