Re: [PATCH net] fou, fou6: avoid uninit-value in gue_err() and gue6_err()

2019-03-08 Thread David Miller
From: Eric Dumazet Date: Wed, 6 Mar 2019 10:41:00 -0800 > My prior commit missed the fact that these functions > were using udp_hdr() (aka skb_transport_header()) > to get access to GUE header. > > Since use pskb_transport_may_pull() does not exist yet, > we have to add transport_offset to our

Re: [PATCH net] fou, fou6: avoid uninit-value in gue_err() and gue6_err()

2019-03-06 Thread Stefano Brivio
On Wed, 6 Mar 2019 10:41:00 -0800 Eric Dumazet wrote: > My prior commit missed the fact that these functions > were using udp_hdr() (aka skb_transport_header()) > to get access to GUE header. Ouch, I totally missed this too. :/ > Since use pskb_transport_may_pull() does not exist yet, Nit: s/

[PATCH net] fou, fou6: avoid uninit-value in gue_err() and gue6_err()

2019-03-06 Thread Eric Dumazet
My prior commit missed the fact that these functions were using udp_hdr() (aka skb_transport_header()) to get access to GUE header. Since use pskb_transport_may_pull() does not exist yet, we have to add transport_offset to our pskb_may_pull() calls. BUG: KMSAN: uninit-value in gue_err+0x514/0xfa0