Re: [PATCH net] ethtool: fix error handling in linkstate_prepare_data()

2020-06-25 Thread David Miller
From: Michal Kubecek Date: Thu, 25 Jun 2020 00:09:08 +0200 (CEST) > When getting SQI or maximum SQI value fails in linkstate_prepare_data(), we > must not return without calling ethnl_ops_complete(dev) as that could > result in imbalance between ethtool_ops ->begin() and ->complete() calls. > >

[PATCH net] ethtool: fix error handling in linkstate_prepare_data()

2020-06-24 Thread Michal Kubecek
When getting SQI or maximum SQI value fails in linkstate_prepare_data(), we must not return without calling ethnl_ops_complete(dev) as that could result in imbalance between ethtool_ops ->begin() and ->complete() calls. Fixes: 806602191592 ("ethtool: provide UAPI for PHY Signal Quality Index (SQI)