From: Xie He
Date: Fri, 28 Aug 2020 00:07:52 -0700
> This driver didn't set hard_header_len. This patch sets hard_header_len
> for it according to its header_ops->create function.
>
> This driver's header_ops->create function (cisco_hard_header) creates
> a header of (struct hdlc_header), so har
On Fri, Aug 28, 2020 at 3:37 AM Krzysztof Hałasa wrote:
>
> OTOH hdlc_setup_dev() initializes hard_header_len to 16,
> but in this case I guess 4 bytes are better.
>
> Acked-by: Krzysztof Halasa
Thank you, Krzysztof!
Actually I'm thinking about changing the default value of 16 in hdlc.c to 0.
Hello Xie,
Xie He writes:
> This driver didn't set hard_header_len. This patch sets hard_header_len
> for it according to its header_ops->create function.
BTW it's 4 bytes long:
struct hdlc_header {
u8 address;
u8 control;
__be16 protocol;
}__packed;
OTOH hdlc_setup_de
This driver didn't set hard_header_len. This patch sets hard_header_len
for it according to its header_ops->create function.
This driver's header_ops->create function (cisco_hard_header) creates
a header of (struct hdlc_header), so hard_header_len should be set to
sizeof(struct hdlc_header).
Cc:
