Re: [PATCH net] dpaa2-eth: prevent array underflow in update_cls_rule()

2020-05-08 Thread Jakub Kicinski
On Fri, 8 May 2020 17:37:20 +0300 Dan Carpenter wrote: > The "location" is controlled by the user via the ethtool_set_rxnfc() > function. This update_cls_rule() function checks for array overflows > but it doesn't check if the value is negative. I have changed the type > to unsigned to prevent ar

[PATCH net] dpaa2-eth: prevent array underflow in update_cls_rule()

2020-05-08 Thread Dan Carpenter
The "location" is controlled by the user via the ethtool_set_rxnfc() function. This update_cls_rule() function checks for array overflows but it doesn't check if the value is negative. I have changed the type to unsigned to prevent array underflows. Fixes: afb90dbb5f78 ("dpaa2-eth: Add ethtool s