Re: [PATCH net] devlink: double free in devlink_resource_fill()

2018-09-23 Thread Jiri Pirko
Fri, Sep 21, 2018 at 10:07:55AM CEST, dan.carpen...@oracle.com wrote: >Smatch reports that devlink_dpipe_send_and_alloc_skb() frees the skb >on error so this is a double free. We fixed a bunch of these bugs in >commit 7fe4d6dcbcb4 ("devlink: Remove redundant free on error path") but >we accidental

[PATCH net] devlink: double free in devlink_resource_fill()

2018-09-21 Thread Dan Carpenter
Smatch reports that devlink_dpipe_send_and_alloc_skb() frees the skb on error so this is a double free. We fixed a bunch of these bugs in commit 7fe4d6dcbcb4 ("devlink: Remove redundant free on error path") but we accidentally overlooked this one. Fixes: d9f9b9a4d05f ("devlink: Add support for re