Re: [PATCH net] dccp/tcp: fix routing redirect race

2017-03-09 Thread David Miller
From: Jon Maxwell Date: Thu, 9 Mar 2017 12:15:21 +1100 > We have seen a few incidents lately where a dst_enty has been freed > with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that > dst_entry. If the conditions/timings are right a crash then ensues when the > freed dst_entry

Re: [PATCH net] dccp/tcp: fix routing redirect race

2017-03-08 Thread Jonathan Maxwell
On Thu, Mar 9, 2017 at 3:40 PM, Eric Dumazet wrote: > On Thu, 2017-03-09 at 14:42 +1100, Jonathan Maxwell wrote: >> Sorry let me resend in plain text mode. >> >> On Thu, Mar 9, 2017 at 1:10 PM, Eric Dumazet wrote: >> > On Thu, 2017-03-09 at 12:15 +1100, Jon Maxwell wrote: >> >> We have seen a few

Re: [PATCH net] dccp/tcp: fix routing redirect race

2017-03-08 Thread Eric Dumazet
On Thu, 2017-03-09 at 14:42 +1100, Jonathan Maxwell wrote: > Sorry let me resend in plain text mode. > > On Thu, Mar 9, 2017 at 1:10 PM, Eric Dumazet wrote: > > On Thu, 2017-03-09 at 12:15 +1100, Jon Maxwell wrote: > >> We have seen a few incidents lately where a dst_enty has been freed > >> with

Re: [PATCH net] dccp/tcp: fix routing redirect race

2017-03-08 Thread Jonathan Maxwell
Sorry let me resend in plain text mode. On Thu, Mar 9, 2017 at 1:10 PM, Eric Dumazet wrote: > On Thu, 2017-03-09 at 12:15 +1100, Jon Maxwell wrote: >> We have seen a few incidents lately where a dst_enty has been freed >> with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that >>

Re: [PATCH net] dccp/tcp: fix routing redirect race

2017-03-08 Thread Eric Dumazet
On Thu, 2017-03-09 at 12:15 +1100, Jon Maxwell wrote: > We have seen a few incidents lately where a dst_enty has been freed > with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that > dst_entry. If the conditions/timings are right a crash then ensues when the > freed dst_entry is r

[PATCH net] dccp/tcp: fix routing redirect race

2017-03-08 Thread Jon Maxwell
We have seen a few incidents lately where a dst_enty has been freed with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that dst_entry. If the conditions/timings are right a crash then ensues when the freed dst_entry is referenced later on. A Common crashing back trace is: #8 [] p