Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-08-18 Thread Veli-Matti Lintu
2016-07-08 15:22 GMT+03:00 Veli-Matti Lintu : > 2016-07-08 4:48 GMT+03:00 Jay Vosburgh : >> diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c >> index edc70ffad660..2da5be91226e 100644 >> --- a/drivers/net/bonding/bond_3ad.c >> +++ b/drivers/net/bonding/bond_3ad.c >> @@

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-07-08 Thread Veli-Matti Lintu
2016-07-08 4:48 GMT+03:00 Jay Vosburgh : > Veli-Matti Lintu wrote: > >>2016-07-06 0:20 GMT+03:00 Jay Vosburgh : >>Thanks for the pointers. Adding some extra debug in __enable_port >>helped me to get in right direction. And adding quite a bit of extra >>debug information after that. >> >>It looks

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-07-07 Thread Jay Vosburgh
Veli-Matti Lintu wrote: >2016-07-06 0:20 GMT+03:00 Jay Vosburgh : >> Veli-Matti Lintu wrote: >> >>>2016-06-30 14:15 GMT+03:00 Veli-Matti Lintu : 2016-06-29 18:59 GMT+03:00 Jay Vosburgh : > Veli-Matti Lintu wrote: >>> > I tried this locally, but don't see any failure (at the

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-07-07 Thread Veli-Matti Lintu
2016-07-06 0:20 GMT+03:00 Jay Vosburgh : > Veli-Matti Lintu wrote: > >>2016-06-30 14:15 GMT+03:00 Veli-Matti Lintu : >>> 2016-06-29 18:59 GMT+03:00 Jay Vosburgh : Veli-Matti Lintu wrote: >> I tried this locally, but don't see any failure (at the end, the "Switch A" agg is s

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-07-05 Thread Jay Vosburgh
Veli-Matti Lintu wrote: >2016-06-30 14:15 GMT+03:00 Veli-Matti Lintu : >> 2016-06-29 18:59 GMT+03:00 Jay Vosburgh : >>> Veli-Matti Lintu wrote: > >>> I tried this locally, but don't see any failure (at the end, the >>> "Switch A" agg is still active with the single port). I am starting

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-07-05 Thread Veli-Matti Lintu
2016-07-05 17:01 GMT+03:00 Veli-Matti Lintu : > 2016-06-30 14:15 GMT+03:00 Veli-Matti Lintu : >> 2016-06-29 18:59 GMT+03:00 Jay Vosburgh : >>> Veli-Matti Lintu wrote: > >>> I tried this locally, but don't see any failure (at the end, the >>> "Switch A" agg is still active with the single p

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-07-05 Thread Jay Vosburgh
Veli-Matti Lintu wrote: [...] >I have understood that only miimon is available with 802.3ad: > >bonding.txt: > >802.3ad: >... >Finally, the 802.3ad mode mandates the use of the MII monitor, >therefore, the ARP monitor is not available in this mode. > >Is there a way to enable ARP m

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-07-05 Thread Veli-Matti Lintu
2016-06-30 14:15 GMT+03:00 Veli-Matti Lintu : > 2016-06-29 18:59 GMT+03:00 Jay Vosburgh : >> Veli-Matti Lintu wrote: >> I tried this locally, but don't see any failure (at the end, the >> "Switch A" agg is still active with the single port). I am starting >> with just two ports in each a

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-07-05 Thread Veli-Matti Lintu
2016-07-01 12:03 GMT+03:00 zhuyj : > " > ... > All testing was done with upstream version 4.6.2 with the patch > applied. When there is no connection, /proc/net/bonding/bond0 still > shows that there is an active aggregator that has a link up, but for > some reason no traffic passes through. I adde

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-06-30 Thread Veli-Matti Lintu
2016-06-29 18:59 GMT+03:00 Jay Vosburgh : > Veli-Matti Lintu wrote: > [...] >>Thanks for the patch. I have been now testing it and the reselection >>seems to be working now in most cases, but I hit one case that seems >>to consistently fail in my test environment. >> >>I've been doing most of test

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-06-29 Thread Jay Vosburgh
Veli-Matti Lintu wrote: [...] >Thanks for the patch. I have been now testing it and the reselection >seems to be working now in most cases, but I hit one case that seems >to consistently fail in my test environment. > >I've been doing most of testing with ad_select=count and this happens >with it.

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-06-28 Thread Veli-Matti Lintu
2016-06-24 0:20 GMT+03:00 Jay Vosburgh : > > Since commit 7bb11dc9f59d ("bonding: unify all places where > actor-oper key needs to be updated."), the logic in bonding to handle > selection between multiple aggregators has not functioned. > > This affects only configurations wherein

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-06-28 Thread David Miller
From: Jay Vosburgh Date: Thu, 23 Jun 2016 14:20:51 -0700 > > Since commit 7bb11dc9f59d ("bonding: unify all places where > actor-oper key needs to be updated."), the logic in bonding to handle > selection between multiple aggregators has not functioned. > > This affects only configu

[PATCH net] bonding: fix 802.3ad aggregator reselection

2016-06-23 Thread Jay Vosburgh
Since commit 7bb11dc9f59d ("bonding: unify all places where actor-oper key needs to be updated."), the logic in bonding to handle selection between multiple aggregators has not functioned. This affects only configurations wherein the bonding slaves connect to two discrete aggregat