Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state

2016-07-19 Thread David Miller
From: Florian Fainelli Date: Mon, 18 Jul 2016 13:02:47 -0700 > txr->dev_state was not consistently manipulated with the acquisition of > the per-queue lock, after further inspection the lock does not seem > necessary, either the value is read as BNXT_DEV_STATE_CLOSING or 0. > > Reported-by: cove

Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state

2016-07-18 Thread Michael Chan
On Mon, Jul 18, 2016 at 1:02 PM, Florian Fainelli wrote: > txr->dev_state was not consistently manipulated with the acquisition of > the per-queue lock, after further inspection the lock does not seem > necessary, either the value is read as BNXT_DEV_STATE_CLOSING or 0. > > Reported-by: coverity (

[PATCH net] bnxt_en: Remove locking around txr->dev_state

2016-07-18 Thread Florian Fainelli
txr->dev_state was not consistently manipulated with the acquisition of the per-queue lock, after further inspection the lock does not seem necessary, either the value is read as BNXT_DEV_STATE_CLOSING or 0. Reported-by: coverity (CID 1339583) Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet