Re: [PATCH net] bnxt: do not busy-poll when link is down

2016-11-24 Thread David Miller
From: Andy Gospodarek Date: Tue, 22 Nov 2016 13:14:08 -0500 > When busy polling while a link is down (during a link-flap test), TX > timeouts were observed as well as the following messages in the ring > buffer: > > bnxt_en 0008:01:00.2 enP8p1s0f2d2: Resp cmpl intr err msg: 0x51 > bnxt_en 0008:0

Re: [PATCH net] bnxt: do not busy-poll when link is down

2016-11-22 Thread Eric Dumazet
On Tue, 2016-11-22 at 10:55 -0800, Michael Chan wrote: > On Tue, Nov 22, 2016 at 10:38 AM, Eric Dumazet wrote: > > > > Any plans removing this busy polling stuff, now it is done in core > > networking stack ? > > > > This would remove bnxt_lock_napi() extra overhead in normal path ( napi > > poll

Re: [PATCH net] bnxt: do not busy-poll when link is down

2016-11-22 Thread Michael Chan
On Tue, Nov 22, 2016 at 10:38 AM, Eric Dumazet wrote: > On Tue, 2016-11-22 at 13:14 -0500, Andy Gospodarek wrote: >> When busy polling while a link is down (during a link-flap test), TX >> timeouts were observed as well as the following messages in the ring >> buffer: >> >> bnxt_en 0008:01:00.2 en

Re: [PATCH net] bnxt: do not busy-poll when link is down

2016-11-22 Thread Eric Dumazet
On Tue, 2016-11-22 at 13:14 -0500, Andy Gospodarek wrote: > When busy polling while a link is down (during a link-flap test), TX > timeouts were observed as well as the following messages in the ring > buffer: > > bnxt_en 0008:01:00.2 enP8p1s0f2d2: Resp cmpl intr err msg: 0x51 > bnxt_en 0008:01:00

[PATCH net] bnxt: do not busy-poll when link is down

2016-11-22 Thread Andy Gospodarek
When busy polling while a link is down (during a link-flap test), TX timeouts were observed as well as the following messages in the ring buffer: bnxt_en 0008:01:00.2 enP8p1s0f2d2: Resp cmpl intr err msg: 0x51 bnxt_en 0008:01:00.2 enP8p1s0f2d2: hwrm_ring_free tx failed. rc:-1 bnxt_en 0008:01:00.2