Re: [PATCH net] be2net: fix initial MAC setting

2017-01-31 Thread Ivan Vecera
My apologies for my previous replies... Gmail sent them as HTML emails that are not acceptable for ML... Thanks, Ivan

Re: [PATCH net] be2net: fix initial MAC setting

2017-01-31 Thread Ivan Vecera
2017-01-31 19:01 GMT+01:00 David Miller : > > > Sriharsha and other Broadcom folks, you must follow-up on Ivan's > explanations and proof of testing. > > It is not acceptable for you to leave this patch's review state in > limbo for days, no matter how complicated or big the patch is. You > must a

Re: [PATCH net] be2net: fix initial MAC setting

2017-01-31 Thread David Miller
Sriharsha and other Broadcom folks, you must follow-up on Ivan's explanations and proof of testing. It is not acceptable for you to leave this patch's review state in limbo for days, no matter how complicated or big the patch is. You must at the very least say what you are doing, and how long it

Re: [PATCH net] be2net: fix initial MAC setting

2017-01-27 Thread Ivan Vecera
2017-01-27 13:38 GMT+01:00 Sriharsha Basavapatna : > Hi Ivan, > > This patch is a bit involved. We need some time to review and test > this to make sure it works with other (non-BE3/VF - Skyhawk, Lancer) > devices. Also, IIRC we shouldn't see this issue with the latest FW. > > Thanks, > -Harsha Bt

Re: [PATCH net] be2net: fix initial MAC setting

2017-01-27 Thread Ivan Vecera
2017-01-27 13:38 GMT+01:00 Sriharsha Basavapatna : > Hi Ivan, > > This patch is a bit involved. We need some time to review and test > this to make sure it works with other (non-BE3/VF - Skyhawk, Lancer) > devices. Also, IIRC we shouldn't see this issue with the latest FW. > I have done tests on BE

Re: [PATCH net] be2net: fix initial MAC setting

2017-01-27 Thread Sriharsha Basavapatna
Hi Ivan, This patch is a bit involved. We need some time to review and test this to make sure it works with other (non-BE3/VF - Skyhawk, Lancer) devices. Also, IIRC we shouldn't see this issue with the latest FW. Thanks, -Harsha On Thu, Jan 26, 2017 at 3:58 PM, Ivan Vecera wrote: > Recent commi

[PATCH net] be2net: fix initial MAC setting

2017-01-26 Thread Ivan Vecera
Recent commit 34393529163a ("be2net: fix MAC addr setting on privileged BE3 VFs") allows privileged BE3 VFs to set its MAC address during initialization. Although the initial MAC for such VFs is already programmed by parent PF the subsequent setting performed by VF is OK, but in certain cases (afte