Re: [PATCH net] bcm63xx_enet: fix sporadic kernel panic

2021-02-23 Thread Jakub Kicinski
On Sun, 21 Feb 2021 21:05:50 -0800 Florian Fainelli wrote: > On 2/21/2021 17:35, Sieng Piaw Liew wrote: > > In ndo_stop functions, netdev_completed_queue() is called during forced > > tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if > > there is any tx skb left. > > > > Thi

Re: [PATCH net] bcm63xx_enet: fix sporadic kernel panic

2021-02-21 Thread Florian Fainelli
On 2/21/2021 17:35, Sieng Piaw Liew wrote: In ndo_stop functions, netdev_completed_queue() is called during forced tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if there is any tx skb left. This patch moves netdev_reset_queue() to after tx reclaim, so BQL can complete

[PATCH net] bcm63xx_enet: fix sporadic kernel panic

2021-02-21 Thread Sieng Piaw Liew
In ndo_stop functions, netdev_completed_queue() is called during forced tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if there is any tx skb left. This patch moves netdev_reset_queue() to after tx reclaim, so BQL can complete successfully then reset. Signed-off-by: Sieng P