Re: [PATCH net] af_packet: fix raw sockets over 6in4 tunnel

2019-01-15 Thread Willem de Bruijn
On Tue, Jan 15, 2019 at 4:49 AM Nicolas Dichtel wrote: > > Le 14/01/2019 à 16:38, Willem de Bruijn a écrit : > > On Mon, Jan 14, 2019 at 10:15 AM Willem de Bruijn > > wrote: > [snip] > >> It is wrong because for other devices l2 header length is not zero, so > >> this incorrectly sets skb->networ

Re: [PATCH net] af_packet: fix raw sockets over 6in4 tunnel

2019-01-15 Thread Nicolas Dichtel
Le 14/01/2019 à 16:38, Willem de Bruijn a écrit : > On Mon, Jan 14, 2019 at 10:15 AM Willem de Bruijn > wrote: [snip] >> It is wrong because for other devices l2 header length is not zero, so >> this incorrectly sets skb->network_header to the start of the link >> layer header on all those devices

Re: [PATCH net] af_packet: fix raw sockets over 6in4 tunnel

2019-01-14 Thread Willem de Bruijn
On Mon, Jan 14, 2019 at 10:15 AM Willem de Bruijn wrote: > > On Mon, Jan 14, 2019 at 9:51 AM Nicolas Dichtel > wrote: > > > > Le 12/01/2019 à 19:00, Willem de Bruijn a écrit : > > > On Fri, Jan 11, 2019 at 4:29 PM Willem de Bruijn > > > wrote: > > >> > > >> On Fri, Jan 11, 2019 at 9:44 AM Nicola

Re: [PATCH net] af_packet: fix raw sockets over 6in4 tunnel

2019-01-14 Thread Willem de Bruijn
On Mon, Jan 14, 2019 at 9:51 AM Nicolas Dichtel wrote: > > Le 12/01/2019 à 19:00, Willem de Bruijn a écrit : > > On Fri, Jan 11, 2019 at 4:29 PM Willem de Bruijn > > wrote: > >> > >> On Fri, Jan 11, 2019 at 9:44 AM Nicolas Dichtel > >> wrote: > >>> > >>> Since commit cb9f1b783850, scapy (which u

Re: [PATCH net] af_packet: fix raw sockets over 6in4 tunnel

2019-01-14 Thread Nicolas Dichtel
Le 12/01/2019 à 19:00, Willem de Bruijn a écrit : > On Fri, Jan 11, 2019 at 4:29 PM Willem de Bruijn > wrote: >> >> On Fri, Jan 11, 2019 at 9:44 AM Nicolas Dichtel >> wrote: >>> >>> Since commit cb9f1b783850, scapy (which uses an AF_PACKET socket in >>> SOCK_RAW mode) is unable to send a basic ic

Re: [PATCH net] af_packet: fix raw sockets over 6in4 tunnel

2019-01-12 Thread Willem de Bruijn
On Fri, Jan 11, 2019 at 4:29 PM Willem de Bruijn wrote: > > On Fri, Jan 11, 2019 at 9:44 AM Nicolas Dichtel > wrote: > > > > Since commit cb9f1b783850, scapy (which uses an AF_PACKET socket in > > SOCK_RAW mode) is unable to send a basic icmp packet over a sit tunnel: > > > > Here is a example of

Re: [PATCH net] af_packet: fix raw sockets over 6in4 tunnel

2019-01-11 Thread Willem de Bruijn
On Fri, Jan 11, 2019 at 9:44 AM Nicolas Dichtel wrote: > > Since commit cb9f1b783850, scapy (which uses an AF_PACKET socket in > SOCK_RAW mode) is unable to send a basic icmp packet over a sit tunnel: > > Here is a example of the setup: > $ ip link set ntfp2 up > $ ip addr add 10.125.0.1/24 dev nt

[PATCH net] af_packet: fix raw sockets over 6in4 tunnel

2019-01-11 Thread Nicolas Dichtel
Since commit cb9f1b783850, scapy (which uses an AF_PACKET socket in SOCK_RAW mode) is unable to send a basic icmp packet over a sit tunnel: Here is a example of the setup: $ ip link set ntfp2 up $ ip addr add 10.125.0.1/24 dev ntfp2 $ ip tunnel add tun1 mode sit ttl 64 local 10.125.0.1 remote 10.1