Re: [PATCH net] 6lowpan: Off by one handling ->nexthdr

2019-04-23 Thread Marcel Holtmann
Hi Dan, > NEXTHDR_MAX is 255. What happens here is that we take a u8 value > "hdr->nexthdr" from the network and then look it up in > lowpan_nexthdr_nhcs[]. The problem is that if hdr->nexthdr is 0xff then > we read one element beyond the end of the array so the array needs to > be one element l

Re: [PATCH net] 6lowpan: Off by one handling ->nexthdr

2019-04-08 Thread Alexander Aring
Hi, On Wed, Apr 03, 2019 at 08:34:16AM +0300, Dan Carpenter wrote: > NEXTHDR_MAX is 255. What happens here is that we take a u8 value > "hdr->nexthdr" from the network and then look it up in > lowpan_nexthdr_nhcs[]. The problem is that if hdr->nexthdr is 0xff then > we read one element beyond th

Re: [PATCH net] 6lowpan: Off by one handling ->nexthdr

2019-04-02 Thread Jukka Rissanen
Hi Dan, On Wed, 2019-04-03 at 08:34 +0300, Dan Carpenter wrote: > NEXTHDR_MAX is 255. What happens here is that we take a u8 value > "hdr->nexthdr" from the network and then look it up in > lowpan_nexthdr_nhcs[]. The problem is that if hdr->nexthdr is 0xff > then > we read one element beyond the

[PATCH net] 6lowpan: Off by one handling ->nexthdr

2019-04-02 Thread Dan Carpenter
NEXTHDR_MAX is 255. What happens here is that we take a u8 value "hdr->nexthdr" from the network and then look it up in lowpan_nexthdr_nhcs[]. The problem is that if hdr->nexthdr is 0xff then we read one element beyond the end of the array so the array needs to be one element larger. Fixes: 92aa