Re: [PATCH net, v1] dccp/tcp: fix routing redirect race

2017-03-09 Thread Jonathan Maxwell
On Fri, Mar 10, 2017 at 3:23 PM, Eric Dumazet wrote: > On Fri, 2017-03-10 at 14:31 +1100, Jon Maxwell wrote: >> As Eric Dumazet pointed out this also needs to be fixed in IPv6. >> v1: Contains the IPv6 patch as well. > >> Fixes: ceb3320610d6 ("ipv4: Kill routes during PMTU/redirect updates.") >> C

Re: [PATCH net, v1] dccp/tcp: fix routing redirect race

2017-03-09 Thread Eric Dumazet
On Fri, 2017-03-10 at 14:31 +1100, Jon Maxwell wrote: > As Eric Dumazet pointed out this also needs to be fixed in IPv6. > v1: Contains the IPv6 patch as well. > Fixes: ceb3320610d6 ("ipv4: Kill routes during PMTU/redirect updates.") > Cc: Eric Garver > Cc: Hannes Sowa > Signed-off-by: Jon Maxwe

[PATCH net, v1] dccp/tcp: fix routing redirect race

2017-03-09 Thread Jon Maxwell
As Eric Dumazet pointed out this also needs to be fixed in IPv6. v1: Contains the IPv6 patch as well. We have seen a few incidents lately where a dst_enty has been freed with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that dst_entry. If the conditions/timings are right a crash