Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-04-01 Thread Leon Romanovsky
On Wed, Mar 31, 2021 at 08:23:40PM -0500, Bjorn Helgaas wrote: > [+cc Rafael, in case you're interested in the driver core issue here] > > On Wed, Mar 31, 2021 at 07:08:07AM +0300, Leon Romanovsky wrote: > > On Tue, Mar 30, 2021 at 03:41:41PM -0500, Bjorn Helgaas wrote: > > > On Tue, Mar 30, 2021

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-31 Thread Bjorn Helgaas
[+cc Rafael, in case you're interested in the driver core issue here] On Wed, Mar 31, 2021 at 07:08:07AM +0300, Leon Romanovsky wrote: > On Tue, Mar 30, 2021 at 03:41:41PM -0500, Bjorn Helgaas wrote: > > On Tue, Mar 30, 2021 at 04:47:16PM -0300, Jason Gunthorpe wrote: > > > On Tue, Mar 30, 2021 at

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-31 Thread Jason Gunthorpe
On Wed, Mar 31, 2021 at 05:03:45PM +0200, Greg Kroah-Hartman wrote: > > It isn't a struct device object at all though, it just organizing > > attributes. > > That's the point, it really is not. You are forced to create a real > object for that subdirectory, and by doing so, you are "breaking" the

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-31 Thread Greg Kroah-Hartman
On Wed, Mar 31, 2021 at 09:19:29AM -0300, Jason Gunthorpe wrote: > On Wed, Mar 31, 2021 at 08:38:39AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Mar 30, 2021 at 07:43:41PM -0300, Jason Gunthorpe wrote: > > > > With :01:00.0/sriov/BB:DD.F/vf_msix_count, sriov/ will contain > > > > 1 file and 1

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-31 Thread Jason Gunthorpe
On Wed, Mar 31, 2021 at 08:38:39AM +0200, Greg Kroah-Hartman wrote: > On Tue, Mar 30, 2021 at 07:43:41PM -0300, Jason Gunthorpe wrote: > > > With :01:00.0/sriov/BB:DD.F/vf_msix_count, sriov/ will contain > > > 1 file and 1K subdirectories. > > > > The smallest directory sizes is with the curre

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-30 Thread Greg Kroah-Hartman
On Tue, Mar 30, 2021 at 07:43:41PM -0300, Jason Gunthorpe wrote: > > With :01:00.0/sriov/BB:DD.F/vf_msix_count, sriov/ will contain > > 1 file and 1K subdirectories. > > The smallest directory sizes is with the current patch since it > re-uses the existing VF directory. Do we care about direct

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-30 Thread Leon Romanovsky
On Tue, Mar 30, 2021 at 03:41:41PM -0500, Bjorn Helgaas wrote: > On Tue, Mar 30, 2021 at 04:47:16PM -0300, Jason Gunthorpe wrote: > > On Tue, Mar 30, 2021 at 10:00:19AM -0500, Bjorn Helgaas wrote: > > > On Tue, Mar 30, 2021 at 10:57:38AM -0300, Jason Gunthorpe wrote: > > > > On Mon, Mar 29, 2021 at

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-30 Thread Jason Gunthorpe
On Tue, Mar 30, 2021 at 03:41:41PM -0500, Bjorn Helgaas wrote: > On Tue, Mar 30, 2021 at 04:47:16PM -0300, Jason Gunthorpe wrote: > > On Tue, Mar 30, 2021 at 10:00:19AM -0500, Bjorn Helgaas wrote: > > > On Tue, Mar 30, 2021 at 10:57:38AM -0300, Jason Gunthorpe wrote: > > > > On Mon, Mar 29, 2021 at

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-30 Thread Bjorn Helgaas
On Tue, Mar 30, 2021 at 04:47:16PM -0300, Jason Gunthorpe wrote: > On Tue, Mar 30, 2021 at 10:00:19AM -0500, Bjorn Helgaas wrote: > > On Tue, Mar 30, 2021 at 10:57:38AM -0300, Jason Gunthorpe wrote: > > > On Mon, Mar 29, 2021 at 08:29:49PM -0500, Bjorn Helgaas wrote: > > > > > > > I think I misund

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-30 Thread Jason Gunthorpe
On Tue, Mar 30, 2021 at 10:00:19AM -0500, Bjorn Helgaas wrote: > On Tue, Mar 30, 2021 at 10:57:38AM -0300, Jason Gunthorpe wrote: > > On Mon, Mar 29, 2021 at 08:29:49PM -0500, Bjorn Helgaas wrote: > > > > > I think I misunderstood Greg's subdirectory comment. We already have > > > directories lik

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-30 Thread Keith Busch
On Mon, Mar 29, 2021 at 08:29:49PM -0500, Bjorn Helgaas wrote: > On Fri, Mar 26, 2021 at 04:01:48PM -0300, Jason Gunthorpe wrote: > > On Fri, Mar 26, 2021 at 11:50:44AM -0700, Alexander Duyck wrote: > > > > > My concern would be that we are defining the user space interface. > > > Once we have thi

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-30 Thread Bjorn Helgaas
On Tue, Mar 30, 2021 at 10:57:38AM -0300, Jason Gunthorpe wrote: > On Mon, Mar 29, 2021 at 08:29:49PM -0500, Bjorn Helgaas wrote: > > > I think I misunderstood Greg's subdirectory comment. We already have > > directories like this: > > Yes, IIRC, Greg's remark applies if you have to start creati

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-30 Thread Jason Gunthorpe
On Mon, Mar 29, 2021 at 08:29:49PM -0500, Bjorn Helgaas wrote: > I think I misunderstood Greg's subdirectory comment. We already have > directories like this: Yes, IIRC, Greg's remark applies if you have to start creating directories with manual kobjects. > and aspm_ctrl_attr_group (for "link")

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-29 Thread Bjorn Helgaas
On Fri, Mar 26, 2021 at 04:01:48PM -0300, Jason Gunthorpe wrote: > On Fri, Mar 26, 2021 at 11:50:44AM -0700, Alexander Duyck wrote: > > > My concern would be that we are defining the user space interface. > > Once we have this working as a single operation I could see us having > > to support it t

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-27 Thread Greg Kroah-Hartman
On Fri, Mar 26, 2021 at 02:36:31PM -0500, Bjorn Helgaas wrote: > On Fri, Mar 26, 2021 at 11:50:44AM -0700, Alexander Duyck wrote: > > > I almost wonder if it wouldn't make sense to just partition this up to > > handle flexible resources in the future. Maybe something like having > > the directory

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Leon Romanovsky
On Fri, Mar 26, 2021 at 02:12:09PM -0300, Jason Gunthorpe wrote: > On Fri, Mar 26, 2021 at 12:08:31PM -0500, Bjorn Helgaas wrote: > > > Leon has implemented a ton of variations, but I don't think having all > > the files in the PF directory was one of them. > > If you promise this is the last of

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Bjorn Helgaas
On Fri, Mar 26, 2021 at 11:50:44AM -0700, Alexander Duyck wrote: > I almost wonder if it wouldn't make sense to just partition this up to > handle flexible resources in the future. Maybe something like having > the directory setup such that you have "sriov_resources/msix/" and > then you could hav

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Jason Gunthorpe
On Fri, Mar 26, 2021 at 11:50:44AM -0700, Alexander Duyck wrote: > My concern would be that we are defining the user space interface. > Once we have this working as a single operation I could see us having > to support it that way going forward as somebody will script something > not expecting an

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Alexander Duyck
On Fri, Mar 26, 2021 at 10:08 AM Bjorn Helgaas wrote: > > On Fri, Mar 26, 2021 at 09:00:50AM -0700, Alexander Duyck wrote: > > On Thu, Mar 25, 2021 at 11:44 PM Leon Romanovsky wrote: > > > On Thu, Mar 25, 2021 at 03:28:36PM -0300, Jason Gunthorpe wrote: > > > > On Thu, Mar 25, 2021 at 01:20:21PM

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Jason Gunthorpe
On Sat, Mar 27, 2021 at 02:29:00AM +0900, Keith Busch wrote: > On Fri, Mar 26, 2021 at 12:08:31PM -0500, Bjorn Helgaas wrote: > > I also want to resurrect your idea of associating > > "sriov_vf_msix_count" with the PF instead of the VF. I really like > > that idea, and it better reflects the way b

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Keith Busch
On Fri, Mar 26, 2021 at 12:08:31PM -0500, Bjorn Helgaas wrote: > I also want to resurrect your idea of associating > "sriov_vf_msix_count" with the PF instead of the VF. I really like > that idea, and it better reflects the way both mlx5 and NVMe work. That is a better match for nvme: we can assi

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Jason Gunthorpe
On Fri, Mar 26, 2021 at 12:08:31PM -0500, Bjorn Helgaas wrote: > Leon has implemented a ton of variations, but I don't think having all > the files in the PF directory was one of them. If you promise this is the last of this bike painting adventure then let's do it. Jason

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Bjorn Helgaas
On Fri, Mar 26, 2021 at 09:00:50AM -0700, Alexander Duyck wrote: > On Thu, Mar 25, 2021 at 11:44 PM Leon Romanovsky wrote: > > On Thu, Mar 25, 2021 at 03:28:36PM -0300, Jason Gunthorpe wrote: > > > On Thu, Mar 25, 2021 at 01:20:21PM -0500, Bjorn Helgaas wrote: > > > > On Thu, Mar 25, 2021 at 02:36

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Jason Gunthorpe
On Fri, Mar 26, 2021 at 09:00:50AM -0700, Alexander Duyck wrote: > On Thu, Mar 25, 2021 at 11:44 PM Leon Romanovsky wrote: > > > > On Thu, Mar 25, 2021 at 03:28:36PM -0300, Jason Gunthorpe wrote: > > > On Thu, Mar 25, 2021 at 01:20:21PM -0500, Bjorn Helgaas wrote: > > > > On Thu, Mar 25, 2021 at 0

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Alexander Duyck
On Thu, Mar 25, 2021 at 11:44 PM Leon Romanovsky wrote: > > On Thu, Mar 25, 2021 at 03:28:36PM -0300, Jason Gunthorpe wrote: > > On Thu, Mar 25, 2021 at 01:20:21PM -0500, Bjorn Helgaas wrote: > > > On Thu, Mar 25, 2021 at 02:36:46PM -0300, Jason Gunthorpe wrote: > > > > On Thu, Mar 25, 2021 at 12:

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-25 Thread Leon Romanovsky
On Thu, Mar 25, 2021 at 03:28:36PM -0300, Jason Gunthorpe wrote: > On Thu, Mar 25, 2021 at 01:20:21PM -0500, Bjorn Helgaas wrote: > > On Thu, Mar 25, 2021 at 02:36:46PM -0300, Jason Gunthorpe wrote: > > > On Thu, Mar 25, 2021 at 12:21:44PM -0500, Bjorn Helgaas wrote: > > > > > > > NVMe and mlx5 ha

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-25 Thread Jason Gunthorpe
On Fri, Mar 26, 2021 at 03:31:57AM +0900, Keith Busch wrote: > The NVMe IO queue resources are assignable just like the MSIx vectors. > But they're not always assigned 1:1. For example: But this is all driver configuration, the driver might be running in some VM. It seems saner to have two kerne

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-25 Thread Keith Busch
On Thu, Mar 25, 2021 at 02:36:46PM -0300, Jason Gunthorpe wrote: > On Thu, Mar 25, 2021 at 12:21:44PM -0500, Bjorn Helgaas wrote: > > > NVMe and mlx5 have basically identical functionality in this respect. > > Other devices and vendors will likely implement similar functionality. > > It would be i

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-25 Thread Jason Gunthorpe
On Thu, Mar 25, 2021 at 01:20:21PM -0500, Bjorn Helgaas wrote: > On Thu, Mar 25, 2021 at 02:36:46PM -0300, Jason Gunthorpe wrote: > > On Thu, Mar 25, 2021 at 12:21:44PM -0500, Bjorn Helgaas wrote: > > > > > NVMe and mlx5 have basically identical functionality in this respect. > > > Other devices a

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-25 Thread Bjorn Helgaas
On Thu, Mar 25, 2021 at 02:36:46PM -0300, Jason Gunthorpe wrote: > On Thu, Mar 25, 2021 at 12:21:44PM -0500, Bjorn Helgaas wrote: > > > NVMe and mlx5 have basically identical functionality in this respect. > > Other devices and vendors will likely implement similar functionality. > > It would be i

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-25 Thread Jason Gunthorpe
On Thu, Mar 25, 2021 at 12:21:44PM -0500, Bjorn Helgaas wrote: > NVMe and mlx5 have basically identical functionality in this respect. > Other devices and vendors will likely implement similar functionality. > It would be ideal if we had an interface generic enough to support > them all. > > Is t

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-25 Thread Bjorn Helgaas
On Thu, Mar 11, 2021 at 05:44:24PM -0400, Jason Gunthorpe wrote: > On Fri, Mar 12, 2021 at 05:50:34AM +0900, Keith Busch wrote: > > On Thu, Mar 11, 2021 at 04:22:34PM -0400, Jason Gunthorpe wrote: > > > On Thu, Mar 11, 2021 at 12:16:02PM -0700, Keith Busch wrote: > > > > On Thu, Mar 11, 2021 at 12:

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-12 Thread Leon Romanovsky
On Fri, Mar 12, 2021 at 08:59:38AM -0800, Alexander Duyck wrote: > On Thu, Mar 11, 2021 at 10:32 PM Leon Romanovsky wrote: > > > > On Thu, Mar 11, 2021 at 06:53:16PM -0800, Alexander Duyck wrote: > > > On Thu, Mar 11, 2021 at 3:21 PM Jason Gunthorpe wrote: > > > > > > > > On Thu, Mar 11, 2021 at

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-12 Thread Leon Romanovsky
On Fri, Mar 12, 2021 at 01:03:19PM -0400, Jason Gunthorpe wrote: > On Fri, Mar 12, 2021 at 08:59:38AM -0800, Alexander Duyck wrote: > > > Lastly by splitting out the onlining step you can avoid potentially > > releasing a broken VF to be reserved if there is some sort of > > unrecoverable error bet

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-12 Thread Jason Gunthorpe
On Fri, Mar 12, 2021 at 08:59:38AM -0800, Alexander Duyck wrote: > Lastly by splitting out the onlining step you can avoid potentially > releasing a broken VF to be reserved if there is some sort of > unrecoverable error between steps 2 and 3. If the PF FW gets in a state that it can't respond to

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-12 Thread Alexander Duyck
On Thu, Mar 11, 2021 at 10:32 PM Leon Romanovsky wrote: > > On Thu, Mar 11, 2021 at 06:53:16PM -0800, Alexander Duyck wrote: > > On Thu, Mar 11, 2021 at 3:21 PM Jason Gunthorpe wrote: > > > > > > On Thu, Mar 11, 2021 at 01:49:24PM -0800, Alexander Duyck wrote: > > > > > We don't need to invent ne

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-12 Thread Keith Busch
On Fri, Mar 12, 2021 at 09:00:17AM -0400, Jason Gunthorpe wrote: > On Thu, Mar 11, 2021 at 06:53:16PM -0800, Alexander Duyck wrote: > > On Thu, Mar 11, 2021 at 3:21 PM Jason Gunthorpe wrote: > > > > > > On Thu, Mar 11, 2021 at 01:49:24PM -0800, Alexander Duyck wrote: > > > > > We don't need to inv

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-12 Thread Jason Gunthorpe
On Thu, Mar 11, 2021 at 06:53:16PM -0800, Alexander Duyck wrote: > On Thu, Mar 11, 2021 at 3:21 PM Jason Gunthorpe wrote: > > > > On Thu, Mar 11, 2021 at 01:49:24PM -0800, Alexander Duyck wrote: > > > > We don't need to invent new locks and new complexity for something > > > > that is trivially so

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Leon Romanovsky
On Thu, Mar 11, 2021 at 06:53:16PM -0800, Alexander Duyck wrote: > On Thu, Mar 11, 2021 at 3:21 PM Jason Gunthorpe wrote: > > > > On Thu, Mar 11, 2021 at 01:49:24PM -0800, Alexander Duyck wrote: > > > > We don't need to invent new locks and new complexity for something > > > > that is trivially so

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Alexander Duyck
On Thu, Mar 11, 2021 at 3:21 PM Jason Gunthorpe wrote: > > On Thu, Mar 11, 2021 at 01:49:24PM -0800, Alexander Duyck wrote: > > > We don't need to invent new locks and new complexity for something > > > that is trivially solved already. > > > > I am not wanting a new lock. What I am wanting is a w

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Jason Gunthorpe
On Thu, Mar 11, 2021 at 01:49:24PM -0800, Alexander Duyck wrote: > > We don't need to invent new locks and new complexity for something > > that is trivially solved already. > > I am not wanting a new lock. What I am wanting is a way to mark the VF > as being stale/offline while we are performing

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Alexander Duyck
On Thu, Mar 11, 2021 at 12:19 PM Jason Gunthorpe wrote: > > On Thu, Mar 11, 2021 at 11:37:28AM -0800, Alexander Duyck wrote: > > > > Then the flow for this could be changed where we take the VF lock and > > mark it as "stale" to prevent any driver binding and then we can > > release the VF lock. N

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Jason Gunthorpe
On Fri, Mar 12, 2021 at 05:50:34AM +0900, Keith Busch wrote: > On Thu, Mar 11, 2021 at 04:22:34PM -0400, Jason Gunthorpe wrote: > > On Thu, Mar 11, 2021 at 12:16:02PM -0700, Keith Busch wrote: > > > On Thu, Mar 11, 2021 at 12:17:29PM -0600, Bjorn Helgaas wrote: > > > > On Wed, Mar 10, 2021 at 03:34

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Keith Busch
On Thu, Mar 11, 2021 at 04:22:34PM -0400, Jason Gunthorpe wrote: > On Thu, Mar 11, 2021 at 12:16:02PM -0700, Keith Busch wrote: > > On Thu, Mar 11, 2021 at 12:17:29PM -0600, Bjorn Helgaas wrote: > > > On Wed, Mar 10, 2021 at 03:34:01PM -0800, Alexander Duyck wrote: > > > > > > > > I'm not so much

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Jason Gunthorpe
On Thu, Mar 11, 2021 at 12:17:29PM -0600, Bjorn Helgaas wrote: > > In addition it still feels rather hacky to be modifying read-only PCIe > > configuration space on the fly via a backdoor provided by the PF. It > > almost feels like this should be some sort of quirk rather than a > > standard feat

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Jason Gunthorpe
On Thu, Mar 11, 2021 at 12:16:02PM -0700, Keith Busch wrote: > On Thu, Mar 11, 2021 at 12:17:29PM -0600, Bjorn Helgaas wrote: > > On Wed, Mar 10, 2021 at 03:34:01PM -0800, Alexander Duyck wrote: > > > > > > I'm not so much worried about management software as the fact that > > > this is a vendor s

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Jason Gunthorpe
On Thu, Mar 11, 2021 at 11:37:28AM -0800, Alexander Duyck wrote: > Then the flow for this could be changed where we take the VF lock and > mark it as "stale" to prevent any driver binding and then we can > release the VF lock. Next we would perform the PF operation telling it > to update the VF.

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Alexander Duyck
On Thu, Mar 11, 2021 at 11:51 AM Leon Romanovsky wrote: > > On Thu, Mar 11, 2021 at 11:37:28AM -0800, Alexander Duyck wrote: > > On Thu, Mar 11, 2021 at 10:17 AM Bjorn Helgaas wrote: > > > > > > On Wed, Mar 10, 2021 at 03:34:01PM -0800, Alexander Duyck wrote: > > > > On Wed, Mar 10, 2021 at 11:09

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Leon Romanovsky
On Thu, Mar 11, 2021 at 11:37:28AM -0800, Alexander Duyck wrote: > On Thu, Mar 11, 2021 at 10:17 AM Bjorn Helgaas wrote: > > > > On Wed, Mar 10, 2021 at 03:34:01PM -0800, Alexander Duyck wrote: > > > On Wed, Mar 10, 2021 at 11:09 AM Bjorn Helgaas wrote: > > > > On Sun, Mar 07, 2021 at 10:55:24AM

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Alexander Duyck
On Thu, Mar 11, 2021 at 10:17 AM Bjorn Helgaas wrote: > > On Wed, Mar 10, 2021 at 03:34:01PM -0800, Alexander Duyck wrote: > > On Wed, Mar 10, 2021 at 11:09 AM Bjorn Helgaas wrote: > > > On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > > > > On Sun, Feb 28, 2021 at 11:55 PM Leon

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Leon Romanovsky
On Thu, Mar 11, 2021 at 12:16:02PM -0700, Keith Busch wrote: > On Thu, Mar 11, 2021 at 12:17:29PM -0600, Bjorn Helgaas wrote: > > On Wed, Mar 10, 2021 at 03:34:01PM -0800, Alexander Duyck wrote: > > > > > > I'm not so much worried about management software as the fact that > > > this is a vendor sp

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Leon Romanovsky
On Thu, Mar 11, 2021 at 12:17:29PM -0600, Bjorn Helgaas wrote: > On Wed, Mar 10, 2021 at 03:34:01PM -0800, Alexander Duyck wrote: > > On Wed, Mar 10, 2021 at 11:09 AM Bjorn Helgaas wrote: > > > On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > > > > On Sun, Feb 28, 2021 at 11:55 P

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Keith Busch
On Thu, Mar 11, 2021 at 12:17:29PM -0600, Bjorn Helgaas wrote: > On Wed, Mar 10, 2021 at 03:34:01PM -0800, Alexander Duyck wrote: > > > > I'm not so much worried about management software as the fact that > > this is a vendor specific implementation detail that is shaping how > > the kernel interf

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Bjorn Helgaas
On Wed, Mar 10, 2021 at 03:34:01PM -0800, Alexander Duyck wrote: > On Wed, Mar 10, 2021 at 11:09 AM Bjorn Helgaas wrote: > > On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > > > On Sun, Feb 28, 2021 at 11:55 PM Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > > > >

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Leon Romanovsky
On Wed, Mar 10, 2021 at 09:21:55PM +0100, Greg Kroah-Hartman wrote: > On Wed, Mar 10, 2021 at 10:10:41PM +0200, Leon Romanovsky wrote: > > On Wed, Mar 10, 2021 at 01:09:06PM -0600, Bjorn Helgaas wrote: > > > On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > > > > On Sun, Feb 28, 20

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-10 Thread Alexander Duyck
On Wed, Mar 10, 2021 at 11:09 AM Bjorn Helgaas wrote: > > On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > > On Sun, Feb 28, 2021 at 11:55 PM Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > @Alexander Duyck, please update me if I can add your ROB tag again > > >

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-10 Thread Greg Kroah-Hartman
On Wed, Mar 10, 2021 at 10:10:41PM +0200, Leon Romanovsky wrote: > On Wed, Mar 10, 2021 at 01:09:06PM -0600, Bjorn Helgaas wrote: > > On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > > > On Sun, Feb 28, 2021 at 11:55 PM Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > >

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-10 Thread Leon Romanovsky
On Wed, Mar 10, 2021 at 01:09:06PM -0600, Bjorn Helgaas wrote: > On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > > On Sun, Feb 28, 2021 at 11:55 PM Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > @Alexander Duyck, please update me if I can add your ROB tag again

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-10 Thread Bjorn Helgaas
On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > On Sun, Feb 28, 2021 at 11:55 PM Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > @Alexander Duyck, please update me if I can add your ROB tag again > > to the series, because you liked v6 more. > > > > Thanks > > > >

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-09 Thread Leon Romanovsky
On Mon, Mar 01, 2021 at 09:55:20AM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky <...> > Leon Romanovsky (4): > PCI: Add a sysfs file to change the MSI-X table size of SR-IOV VFs > net/mlx5: Add dynamic MSI-X capabilities bits > net/mlx5: Dynamically assign MSI-X vectors count >

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-08 Thread Leon Romanovsky
On Mon, Mar 08, 2021 at 08:33:03AM -0800, Alexander Duyck wrote: > On Sun, Mar 7, 2021 at 11:19 AM Leon Romanovsky wrote: > > > > On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > > > On Sun, Feb 28, 2021 at 11:55 PM Leon Romanovsky wrote: > > > > > > > > From: Leon Romanovsky >

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-08 Thread Alexander Duyck
On Sun, Mar 7, 2021 at 11:19 AM Leon Romanovsky wrote: > > On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > > On Sun, Feb 28, 2021 at 11:55 PM Leon Romanovsky wrote: > > > > > > From: Leon Romanovsky > > > > > > @Alexander Duyck, please update me if I can add your ROB tag again

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-07 Thread Leon Romanovsky
On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > On Sun, Feb 28, 2021 at 11:55 PM Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > @Alexander Duyck, please update me if I can add your ROB tag again > > to the series, because you liked v6 more. > > > > Thanks > > > >

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-07 Thread Alexander Duyck
On Sun, Feb 28, 2021 at 11:55 PM Leon Romanovsky wrote: > > From: Leon Romanovsky > > @Alexander Duyck, please update me if I can add your ROB tag again > to the series, because you liked v6 more. > > Thanks > > - > C

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-07 Thread Leon Romanovsky
On Mon, Mar 01, 2021 at 09:55:20AM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > @Alexander Duyck, please update me if I can add your ROB tag again > to the series, because you liked v6 more. > > Thanks > > ---

[PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-02-28 Thread Leon Romanovsky
From: Leon Romanovsky @Alexander Duyck, please update me if I can add your ROB tag again to the series, because you liked v6 more. Thanks - Changelog v7: * Rebase on top v5.12-rc1 * More english fixes * Returned