Re: [PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64

2019-01-25 Thread Saeed Mahameed
On Mon, 2019-01-21 at 18:22 +, Jason Gunthorpe wrote: > On Mon, Jan 21, 2019 at 10:12:58AM -0800, Saeed Mahameed wrote: > > On Mon, Jan 21, 2019 at 8:46 AM Jason Gunthorpe > > wrote: > > > On Sat, Jan 19, 2019 at 12:43:14AM -0700, Leon Romanovsky wrote: > > > > You need to do one of two things

Re: [PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64

2019-01-21 Thread Jason Gunthorpe
On Mon, Jan 21, 2019 at 10:12:58AM -0800, Saeed Mahameed wrote: > On Mon, Jan 21, 2019 at 8:46 AM Jason Gunthorpe wrote: > > > > On Sat, Jan 19, 2019 at 12:43:14AM -0700, Leon Romanovsky wrote: > > > You need to do one of two things: > > > 1. Require CONFIG_64BIT and delete this 32bit code. > > >

Re: [PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64

2019-01-21 Thread Saeed Mahameed
On Mon, Jan 21, 2019 at 8:46 AM Jason Gunthorpe wrote: > > On Sat, Jan 19, 2019 at 12:43:14AM -0700, Leon Romanovsky wrote: > > You need to do one of two things: > > 1. Require CONFIG_64BIT and delete this 32bit code. > > 2. Declare global mlx5 DB spinlock and use on 32bit systems, something > > l

Re: [PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64

2019-01-21 Thread Saeed Mahameed
On Fri, Jan 18, 2019 at 11:43 PM Leon Romanovsky wrote: > > On Fri, Jan 18, 2019 at 04:33:13PM -0800, Saeed Mahameed wrote: > > From: Maxim Mikityanskiy > > > > As there is no user of mlx5_write64 that passes a spinlock to > > mlx5_write64, remove this functionality and simplify the function. > >

Re: [PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64

2019-01-21 Thread Jason Gunthorpe
On Sat, Jan 19, 2019 at 12:43:14AM -0700, Leon Romanovsky wrote: > You need to do one of two things: > 1. Require CONFIG_64BIT and delete this 32bit code. > 2. Declare global mlx5 DB spinlock and use on 32bit systems, something > like this: > #if BITS_PER_LONG == 64 > __raw_writeq(*(u64 *)val, des

Re: [PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64

2019-01-18 Thread Leon Romanovsky
On Fri, Jan 18, 2019 at 04:33:13PM -0800, Saeed Mahameed wrote: > From: Maxim Mikityanskiy > > As there is no user of mlx5_write64 that passes a spinlock to > mlx5_write64, remove this functionality and simplify the function. > > Signed-off-by: Maxim Mikityanskiy > Reviewed-by: Eran Ben Elisha >

[PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64

2019-01-18 Thread Saeed Mahameed
From: Maxim Mikityanskiy As there is no user of mlx5_write64 that passes a spinlock to mlx5_write64, remove this functionality and simplify the function. Signed-off-by: Maxim Mikityanskiy Reviewed-by: Eran Ben Elisha Signed-off-by: Saeed Mahameed --- drivers/infiniband/hw/mlx5/qp.c