Re: [PATCH ipvs-next] ipvs: avoid indirect calls when calculating checksums

2019-01-23 Thread Simon Horman
On Sun, Jan 20, 2019 at 02:11:31PM +0200, Julian Anastasov wrote: > > Hello, > > On Sat, 19 Jan 2019, Matteo Croce wrote: > > > The function pointer ip_vs_protocol->csum_check is only used in protocol > > specific code, and never in the generic one. > > Remove the function pointer from str

Re: [PATCH ipvs-next] ipvs: avoid indirect calls when calculating checksums

2019-01-20 Thread Julian Anastasov
Hello, On Sat, 19 Jan 2019, Matteo Croce wrote: > The function pointer ip_vs_protocol->csum_check is only used in protocol > specific code, and never in the generic one. > Remove the function pointer from struct ip_vs_protocol and call the > checksum functions directly. > This reduces t

[PATCH ipvs-next] ipvs: avoid indirect calls when calculating checksums

2019-01-19 Thread Matteo Croce
The function pointer ip_vs_protocol->csum_check is only used in protocol specific code, and never in the generic one. Remove the function pointer from struct ip_vs_protocol and call the checksum functions directly. This reduces the performance impact of the Spectre mitigation, and should give a sma