Re: [PATCH ipsec 7/7] xfrm: policy: fix infinite loop when merging src-nodes

2019-01-09 Thread Steffen Klassert
On Sat, Jan 05, 2019 at 10:59:08AM +0100, Florian Westphal wrote: > Cong Wang wrote: > > > - hlist_for_each_entry(tmp, &node->hhead, bydst) > > > - tmp->bydst_reinsert = true; > > > - hlist_for_each_entry(tmp, &n->hhead, byd

Re: [PATCH ipsec 7/7] xfrm: policy: fix infinite loop when merging src-nodes

2019-01-05 Thread Florian Westphal
Cong Wang wrote: > > - hlist_for_each_entry(tmp, &node->hhead, bydst) > > - tmp->bydst_reinsert = true; > > - hlist_for_each_entry(tmp, &n->hhead, bydst) > > + hlist_for_each_entry(tmp, &n->hhead, bydst

Re: [PATCH ipsec 7/7] xfrm: policy: fix infinite loop when merging src-nodes

2019-01-04 Thread Cong Wang
On Fri, Jan 4, 2019 at 5:19 AM Florian Westphal wrote: > > With very small change to test script we can trigger softlockup due to > bogus assignment of 'p' (policy to be examined) on restart. > > Previously the two to-be-merged nodes had same address/prefixlength pair, > so no erase/reinsert was n

[PATCH ipsec 7/7] xfrm: policy: fix infinite loop when merging src-nodes

2019-01-04 Thread Florian Westphal
With very small change to test script we can trigger softlockup due to bogus assignment of 'p' (policy to be examined) on restart. Previously the two to-be-merged nodes had same address/prefixlength pair, so no erase/reinsert was necessary, we only had to append the list from node a to b. If pref