Re: [PATCH ipsec-next 03/11] xfrm: remove input indirection from xfrm_mode

2019-03-29 Thread Florian Westphal
Eyal Birger wrote: > > diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c > > index ea5ac053c15d..e3c7edd11e77 100644 > > --- a/net/xfrm/xfrm_input.c > > +++ b/net/xfrm/xfrm_input.c > > @@ -186,6 +186,74 @@ int xfrm_prepare_input(struct xfrm_state *x, struct > > sk_buff *skb) > > } > >

Re: [PATCH ipsec-next 03/11] xfrm: remove input indirection from xfrm_mode

2019-03-29 Thread Eyal Birger
Hi Florian, On Wed, Mar 27, 2019 at 7:31 PM Florian Westphal wrote: > > No need for any indirection or abstraction here, both functions > are pretty much the same and quite small, they also have no external > dependencies. >. > diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c > index ea

Re: [PATCH ipsec-next 03/11] xfrm: remove input indirection from xfrm_mode

2019-03-28 Thread Florian Westphal
Sabrina Dubroca wrote: > 2019-03-27, 18:31:32 +0100, Florian Westphal wrote: > > diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c > > index ea5ac053c15d..e3c7edd11e77 100644 > > --- a/net/xfrm/xfrm_input.c > > +++ b/net/xfrm/xfrm_input.c > > @@ -186,6 +186,74 @@ int xfrm_prepare_input(st

Re: [PATCH ipsec-next 03/11] xfrm: remove input indirection from xfrm_mode

2019-03-28 Thread Sabrina Dubroca
2019-03-27, 18:31:32 +0100, Florian Westphal wrote: > diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c > index ea5ac053c15d..e3c7edd11e77 100644 > --- a/net/xfrm/xfrm_input.c > +++ b/net/xfrm/xfrm_input.c > @@ -186,6 +186,74 @@ int xfrm_prepare_input(struct xfrm_state *x, struct > sk_buf

[PATCH ipsec-next 03/11] xfrm: remove input indirection from xfrm_mode

2019-03-27 Thread Florian Westphal
No need for any indirection or abstraction here, both functions are pretty much the same and quite small, they also have no external dependencies. With allmodconfig build, size increase of vmlinux is 25 byte: Before: text data bss dec filename 15730207 6936924 4046908 26714039