Re: [PATCH ipsec] xfrm: Pass template address family to xfrm_state_look_at

2020-11-03 Thread Anthony DeRossi
On Tue, Nov 3, 2020 at 4:08 AM Herbert Xu wrote: > > On Mon, Nov 02, 2020 at 06:32:19PM -0800, Anthony DeRossi wrote: > > This fixes a regression where valid selectors are incorrectly skipped > > when xfrm_state_find is called with a non-matching address family (e.g. > > when using IPv6-in-IPv4 ES

Re: [PATCH ipsec] xfrm: Pass template address family to xfrm_state_look_at

2020-11-03 Thread Anthony DeRossi
On Tue, Nov 3, 2020 at 4:05 AM Herbert Xu wrote: > > On Mon, Nov 02, 2020 at 06:32:19PM -0800, Anthony DeRossi wrote: > > This fixes a regression where valid selectors are incorrectly skipped > > when xfrm_state_find is called with a non-matching address family (e.g. > > when using IPv6-in-IPv4 ES

Re: [PATCH ipsec] xfrm: Pass template address family to xfrm_state_look_at

2020-11-03 Thread Herbert Xu
On Mon, Nov 02, 2020 at 06:32:19PM -0800, Anthony DeRossi wrote: > This fixes a regression where valid selectors are incorrectly skipped > when xfrm_state_find is called with a non-matching address family (e.g. > when using IPv6-in-IPv4 ESP in transport mode). Why are we even allowing v6-over-v4 i

Re: [PATCH ipsec] xfrm: Pass template address family to xfrm_state_look_at

2020-11-03 Thread Herbert Xu
On Mon, Nov 02, 2020 at 06:32:19PM -0800, Anthony DeRossi wrote: > This fixes a regression where valid selectors are incorrectly skipped > when xfrm_state_find is called with a non-matching address family (e.g. > when using IPv6-in-IPv4 ESP in transport mode). > > The state's address family is mat

[PATCH ipsec] xfrm: Pass template address family to xfrm_state_look_at

2020-11-02 Thread Anthony DeRossi
This fixes a regression where valid selectors are incorrectly skipped when xfrm_state_find is called with a non-matching address family (e.g. when using IPv6-in-IPv4 ESP in transport mode). The state's address family is matched against the template's family (encap_family) in xfrm_state_find before