Re: [PATCH ipsec, resend 1/1] xfrm: Make set-mark default behavior backward compatible

2019-01-17 Thread Steffen Klassert
On Mon, Jan 14, 2019 at 11:24:38AM -0800, Benedict Wong wrote: > Fixes 9b42c1f179a6, which changed the default route lookup behavior for > tunnel mode SAs in the outbound direction to use the skb mark, whereas > previously mark=0 was used if the output mark was unspecified. In > mark-based routing

Re: [PATCH ipsec, resend 1/1] xfrm: Make set-mark default behavior backward compatible

2019-01-15 Thread Benedict Wong
Hi Eyal, Thanks for taking a look at this. > It's a little sad that we didn't distinguish between 'no-mark-provided' > and 'mark = mask = 0'. IIUC before this fix, explicitly setting mark, > mask to a) mark = 0, mask = 0x and b) mark = 0, mask = 0 behaved > differently, whereas after this

Re: [PATCH ipsec, resend 1/1] xfrm: Make set-mark default behavior backward compatible

2019-01-14 Thread Eyal Birger
Hi Benedict, On Mon, 14 Jan 2019 11:24:38 -0800 Benedict Wong wrote: > Fixes 9b42c1f179a6, which changed the default route lookup behavior > for tunnel mode SAs in the outbound direction to use the skb mark, > whereas previously mark=0 was used if the output mark was > unspecified. In mark-based

[PATCH ipsec, resend 1/1] xfrm: Make set-mark default behavior backward compatible

2019-01-14 Thread Benedict Wong
Fixes 9b42c1f179a6, which changed the default route lookup behavior for tunnel mode SAs in the outbound direction to use the skb mark, whereas previously mark=0 was used if the output mark was unspecified. In mark-based routing schemes such as Android’s, this change in default behavior causes routi

[PATCH ipsec, resend 1/1] xfrm: Make set-mark default behavior backward compatible

2019-01-11 Thread Benedict Wong
Fixes 9b42c1f179a6, which changed the default route lookup behavior for tunnel mode SAs in the outbound direction to use the skb mark, whereas previously mark=0 was used if the output mark was unspecified. In mark-based routing schemes such as Android’s, this change in default behavior causes routi