On Thu, Dec 15, 2016 at 3:00 PM, Nogah Frankel wrote:
> +/* Note: if one xstat name in subset of another, it should be before it in
> this
> + * list.
> + * Name length must be under 64 chars.
> + */
nit "in subset" --> "is subset" ?
; Or Gerlitz
> Subject: Re: [PATCH iproute2 v2 1/3] ifstat: Add extended statistics to ifstat
>
> Hi,
>
> >Thanks, I'll fix it.
> Another minor nit, on this occasion:
>
> bool is_extanded should be: bool is_extended
>
> Regards,
> Rami Rosen
Thank you, I will fix it.
Nogah
Hi,
>Thanks, I'll fix it.
Another minor nit, on this occasion:
bool is_extanded should be: bool is_extended
Regards,
Rami Rosen
litz
>
> Subject: Re: [PATCH iproute2 v2 1/3] ifstat: Add extended statistics to ifstat
>
> On Thu, 15 Dec 2016 15:00:43 +0200
> Nogah Frankel wrote:
>
> > Extended stats are part of the RTM_GETSTATS method. This patch adds them
> > to ifstat.
> > While e
On Thu, 15 Dec 2016 15:00:43 +0200
Nogah Frankel wrote:
> Extended stats are part of the RTM_GETSTATS method. This patch adds them
> to ifstat.
> While extended stats can come in many forms, we support only the
> rtnl_link_stats64 struct for them (which is the 64 bits version of struct
> rtnl_lin
Extended stats are part of the RTM_GETSTATS method. This patch adds them
to ifstat.
While extended stats can come in many forms, we support only the
rtnl_link_stats64 struct for them (which is the 64 bits version of struct
rtnl_link_stats).
We support stats in the main nesting level, or one lower.
