Re: [PATCH iproute2 v2 0/3] refactor the cmd_exec()

2019-06-20 Thread Stephen Hemminger
On Tue, 18 Jun 2019 16:49:32 +0200 Matteo Croce wrote: > Refactor the netns and ipvrf code so less steps are needed to exec commands > in a netns or a VRF context. > Also remove some code which became dead. bloat-o-meter shows a tiny saving. > > Matteo Croce (3): > netns: switch netns in the c

Re: [PATCH iproute2 v2 0/3] refactor the cmd_exec()

2019-06-18 Thread Matteo Croce
On Tue, Jun 18, 2019 at 4:49 PM Matteo Croce wrote: > > Refactor the netns and ipvrf code so less steps are needed to exec commands > in a netns or a VRF context. > Also remove some code which became dead. bloat-o-meter shows a tiny saving. > > Matteo Croce (3): > netns: switch netns in the chil

[PATCH iproute2 v2 0/3] refactor the cmd_exec()

2019-06-18 Thread Matteo Croce
Refactor the netns and ipvrf code so less steps are needed to exec commands in a netns or a VRF context. Also remove some code which became dead. bloat-o-meter shows a tiny saving. Matteo Croce (3): netns: switch netns in the child when executing commands ip vrf: use hook to change VRF in the

Re: [PATCH iproute2 v2 0/3] refactor the cmd_exec()

2019-06-17 Thread David Ahern
On 6/17/19 4:20 PM, Matteo Croce wrote: > > I looked for every occourrence of netns_switch(): > > bridge/bridge.c:if (netns_switch(argv[1])) > include/namespace.h:int netns_switch(char *netns); > ip/ip.c:if (netns_switch(argv[1])) > ip/ipnetns.c:

Re: [PATCH iproute2 v2 0/3] refactor the cmd_exec()

2019-06-17 Thread Matteo Croce
On Sat, Jun 15, 2019 at 4:06 PM Matteo Croce wrote: > > On Fri, Jun 14, 2019 at 4:36 PM David Ahern wrote: > > > > On 6/11/19 10:10 AM, Matteo Croce wrote: > > > Refactor the netns and ipvrf code so less steps are needed to exec > > > commands > > > in a netns or a VRF context. > > > Also remove

Re: [PATCH iproute2 v2 0/3] refactor the cmd_exec()

2019-06-15 Thread Matteo Croce
On Fri, Jun 14, 2019 at 4:36 PM David Ahern wrote: > > On 6/11/19 10:10 AM, Matteo Croce wrote: > > Refactor the netns and ipvrf code so less steps are needed to exec commands > > in a netns or a VRF context. > > Also remove some code which became dead. bloat-o-meter output: > > > > This breaks th

Re: [PATCH iproute2 v2 0/3] refactor the cmd_exec()

2019-06-14 Thread David Ahern
On 6/11/19 10:10 AM, Matteo Croce wrote: > Refactor the netns and ipvrf code so less steps are needed to exec commands > in a netns or a VRF context. > Also remove some code which became dead. bloat-o-meter output: > This breaks the vrf reset after namespace switch # ip vrf ls Name

Re: [PATCH iproute2 v2 0/3] refactor the cmd_exec()

2019-06-13 Thread Andrea Claudi
On Tue, Jun 11, 2019 at 6:11 PM Matteo Croce wrote: > > Refactor the netns and ipvrf code so less steps are needed to exec commands > in a netns or a VRF context. > Also remove some code which became dead. bloat-o-meter output: > > $ bloat-o-meter ip.old ip > add/remove: 1/4 grow/shrink: 3/4 up/do

[PATCH iproute2 v2 0/3] refactor the cmd_exec()

2019-06-11 Thread Matteo Croce
Refactor the netns and ipvrf code so less steps are needed to exec commands in a netns or a VRF context. Also remove some code which became dead. bloat-o-meter output: $ bloat-o-meter ip.old ip add/remove: 1/4 grow/shrink: 3/4 up/down: 174/-312 (-138) Function o