Re: [PATCH iproute2 net-next v3 3/5] taprio: add support for setting txtime_delay.

2019-07-15 Thread Patel, Vedang
> On Jul 15, 2019, at 4:38 PM, Stephen Hemminger > wrote: > > On Mon, 15 Jul 2019 15:51:42 -0700 > Vedang Patel wrote: > >> +if (get_s32(&txtime_delay, *argv, 0)) { > > Is txtime_delay of a negative value meaningful? No, txtime-delay should always be a positive value.

Re: [PATCH iproute2 net-next v3 3/5] taprio: add support for setting txtime_delay.

2019-07-15 Thread Stephen Hemminger
On Mon, 15 Jul 2019 15:51:42 -0700 Vedang Patel wrote: > + if (get_s32(&txtime_delay, *argv, 0)) { Is txtime_delay of a negative value meaningful?

[PATCH iproute2 net-next v3 3/5] taprio: add support for setting txtime_delay.

2019-07-15 Thread Vedang Patel
This adds support for setting the txtime_delay parameter which is useful for the txtime offload mode of taprio. Signed-off-by: Vedang Patel --- tc/q_taprio.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/tc/q_taprio.c b/tc/q_taprio.c index 930ecb9d1e