Re: [PATCH iproute2 net-next] ip: add a new parameter -Numeric

2019-05-21 Thread David Ahern
On 5/21/19 6:13 AM, Hangbin Liu wrote: > BTW, for some pre-defined names in iproute2, like rtnl_rtprot_tab, > nl_proto_tab. Should we also print the number directly or just keep > using the human readable names? > > I would like to keep them as this is defined in iproute and we can control > them.

Re: [PATCH iproute2 net-next] ip: add a new parameter -Numeric

2019-05-21 Thread Hangbin Liu
On Mon, May 20, 2019 at 10:03:22AM -0700, Stephen Hemminger wrote: > On Mon, 20 May 2019 09:18:08 -0600 > David Ahern wrote: > > > On 5/20/19 1:56 AM, Hangbin Liu wrote: > > > When calles rtnl_dsfield_n2a(), we get the dsfield name from > > > /etc/iproute2/rt_dsfield. But different distribution m

Re: [PATCH iproute2 net-next] ip: add a new parameter -Numeric

2019-05-20 Thread Stephen Hemminger
On Mon, 20 May 2019 09:18:08 -0600 David Ahern wrote: > On 5/20/19 1:56 AM, Hangbin Liu wrote: > > When calles rtnl_dsfield_n2a(), we get the dsfield name from > > /etc/iproute2/rt_dsfield. But different distribution may have > > different names. So add a new parameter '-Numeric' to only show > >

Re: [PATCH iproute2 net-next] ip: add a new parameter -Numeric

2019-05-20 Thread David Ahern
On 5/20/19 1:56 AM, Hangbin Liu wrote: > When calles rtnl_dsfield_n2a(), we get the dsfield name from > /etc/iproute2/rt_dsfield. But different distribution may have > different names. So add a new parameter '-Numeric' to only show > the dsfield number. > > This parameter is only used for tos valu

Re: [PATCH iproute2 net-next] ip: add a new parameter -Numeric

2019-05-20 Thread Phil Sutter
Hi, On Mon, May 20, 2019 at 03:56:48PM +0800, Hangbin Liu wrote: > When calles rtnl_dsfield_n2a(), we get the dsfield name from > /etc/iproute2/rt_dsfield. But different distribution may have > different names. So add a new parameter '-Numeric' to only show > the dsfield number. > > This paramete

[PATCH iproute2 net-next] ip: add a new parameter -Numeric

2019-05-20 Thread Hangbin Liu
When calles rtnl_dsfield_n2a(), we get the dsfield name from /etc/iproute2/rt_dsfield. But different distribution may have different names. So add a new parameter '-Numeric' to only show the dsfield number. This parameter is only used for tos value at present. We could enable this for other fields