Re: [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api

2016-05-11 Thread Jamal Hadi Salim
On 16-05-10 12:25 PM, Roopa Prabhu wrote: On 5/9/16, 5:38 AM, Jamal Hadi Salim wrote: Is it not possible to convert to 64b - and IFLA_STAT becomes available just store it still in 64b? i.e 32b will fit in 64b space. The only problem is again if the last saved history file had 32 bit and 32bi

Re: [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api

2016-05-10 Thread Roopa Prabhu
On 5/9/16, 5:38 AM, Jamal Hadi Salim wrote: > On 16-05-09 12:49 AM, Roopa Prabhu wrote: >> On 4/30/16, 8:15 AM, Roopa Prabhu wrote: >>> On 4/30/16, 3:21 AM, Jamal Hadi Salim wrote: > >> AFAICS ifstat history file handling today assumes all 32 bit stats. > > Indeed it does. > >> And to preserve back

Re: [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api

2016-05-09 Thread Jamal Hadi Salim
On 16-05-09 12:49 AM, Roopa Prabhu wrote: On 4/30/16, 8:15 AM, Roopa Prabhu wrote: On 4/30/16, 3:21 AM, Jamal Hadi Salim wrote: AFAICS ifstat history file handling today assumes all 32 bit stats. Indeed it does. And to preserve backward compatibility, new ifstat should work with old and n

Re: [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api

2016-05-08 Thread Roopa Prabhu
On 4/30/16, 8:15 AM, Roopa Prabhu wrote: > On 4/30/16, 3:21 AM, Jamal Hadi Salim wrote: >> On 16-04-30 02:41 AM, Roopa Prabhu wrote: >>> From: Roopa Prabhu >>> >>> This patch modifies ifstat to use the new RTM_GETSTATS api >>> to query stats from the kernel. In the process this also >>> moves ifst

Re: [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api

2016-04-30 Thread Roopa Prabhu
On 4/30/16, 3:21 AM, Jamal Hadi Salim wrote: > On 16-04-30 02:41 AM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> This patch modifies ifstat to use the new RTM_GETSTATS api >> to query stats from the kernel. In the process this also >> moves ifstat to use 64 bit stats. > > Breaks old kernels? M

Re: [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api

2016-04-30 Thread Jamal Hadi Salim
On 16-04-30 02:41 AM, Roopa Prabhu wrote: From: Roopa Prabhu This patch modifies ifstat to use the new RTM_GETSTATS api to query stats from the kernel. In the process this also moves ifstat to use 64 bit stats. Breaks old kernels? May need to keep backward compat of RTM_NEWLINK and even new m

[PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api

2016-04-29 Thread Roopa Prabhu
From: Roopa Prabhu This patch modifies ifstat to use the new RTM_GETSTATS api to query stats from the kernel. In the process this also moves ifstat to use 64 bit stats. Signed-off-by: Roopa Prabhu --- include/libnetlink.h | 3 +++ include/linux/if_link.h | 22 ++ in